Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded "gem signout" step from Ruby release #108

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Remove unneeded "gem signout" step from Ruby release #108

merged 1 commit into from
Feb 7, 2023

Commits on Feb 3, 2023

  1. Remove unneeded "gem signout" step from Ruby release 

    **What does this PR do?**:

This PR removes the now-unneeded "gem signout" steps during the Ruby
release process.

**Motivation**:

In #85, we changed the way that we authenticate with rubygems.org when
pushing a new libdatadog release.

I just did a release with this new code, and noticed that because
we no longer log in, but just use a limited API key, the "gem signout"
does not do anything and emits an error.

Here's what I saw when I ran `docker-compose run push_to_rubygems`:

```
... preparation of packages goes here...

ERROR:  You are not currently signed in.
Please input 'libdatadog ruby release key' from 'Profiling - Falcon' Datadog 1Password:
(...key...)
Pushing gem to https://rubygems.org...
You have enabled multi-factor authentication. Please enter OTP code.
Code:   (...)
Successfully registered gem: libdatadog (2.0.0.1.0)
Pushing gem to https://rubygems.org...
You have enabled multi-factor authentication. Please enter OTP code.
Code:   (...)
Successfully registered gem: libdatadog (2.0.0.1.0-x86_64-linux)
Pushing gem to https://rubygems.org...
You have enabled multi-factor authentication. Please enter OTP code.
Code:   (...)
Successfully registered gem: libdatadog (2.0.0.1.0-aarch64-linux)
ERROR:  You are not currently signed in.
```

Those two "ERROR:  You are not currently signed in" come from the
"gem signout" steps, and what's why I'm removing them.

**Additional Notes**:

(N/A)

**How to test the change?**:

You can run `docker-compose run push_to_rubygems` and validate
the errors will not show up again. This is safe because Rubygems
does not allow re-releasing the same packages.
    @ivoanjo
    ivoanjo committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    24298b6 View commit details
    Browse the repository at this point in the history