Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini Agent: use lzma upx compression when building for release #156

Merged
merged 2 commits into from
May 8, 2023

Conversation

thedavl
Copy link
Contributor

@thedavl thedavl commented May 5, 2023

What does this PR do?

Compressing with upx "$filename" --ultra-brute in a ubuntu-latest github workflow broke the executable and made it un-runnable. Using --lzma worked correctly however

Using lzma compression decreases binary size by 10KB.

How to test the change?

Tested the workflow manually, verified the mini agent binary executes properly. Tested the --lzma compressed binary in Google Cloud Functions and found a negligible performance difference over 20 cold start invocations.

@thedavl thedavl marked this pull request as ready for review May 8, 2023 17:18
@thedavl thedavl requested a review from a team as a code owner May 8, 2023 17:18
@thedavl thedavl merged commit bccf173 into main May 8, 2023
@thedavl thedavl deleted the david.lee/mini-agent-build-workflow-lzma branch May 8, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants