Mini Agent: Verify azure function env w/ filesystem #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavl
changed the title
maxday
reviewed
Jun 13, 2023
trace-mini-agent/src/config.rs
Outdated
| } | ||
|
|
||
| let env_type = maybe_env_type.unwrap_or_else(|| { |
There was a problem hiding this comment.
Could we avoid using #[cfg(not(test))] and #[cfg(test)] here?
There was a problem hiding this comment.
fixed! process::exit is actually unnecessary here, we can just return
…aDog/libdatadog into david.lee/mini-agent-az-verification
maxday
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checks the azure function filesystem at specific paths for two files (host.json and function.json) to verify we're running in an azure function environment.
Motivation
azure functions (consumption plan) support
Additional Notes
How to test the change?
Unit tested + manually tested with linux + windows azure functions.