Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the telemetry worker #18

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

paullegranddc
Copy link
Contributor

What does this PR do?

Separate the telemetry payload building from sending, in order to appease the borrow checker [T]/ and remove boxing.

Separate payload building from sending, in orider to appease the borrow checker \[T]/
@paullegranddc paullegranddc requested a review from a team as a code owner May 31, 2022 14:20
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Looks good to me

@paullegranddc paullegranddc merged commit a416089 into main Jun 1, 2022
@morrisonlevi morrisonlevi deleted the paullgdc/remove_boxing_in_worker branch January 27, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants