Minor: Add help message on CI failure #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: Add a tiny message pointing people in the right direction if something fails in GitLab CI. **Motivation**: I got confused by this, so might as well improve it so that I'm the last person to be confused :) **Additional Notes**: N/A **How to test the change?**: Validate that this message shows up when going to the "report_gitlab_CI_status" job in CI.
paullegranddc
approved these changes
Jun 28, 2023
ivoanjo
added a commit
that referenced
this pull request
Jun 28, 2023
**What does this PR do?**: Fix a bug in YAML syntax introduced in #182. **Motivation**: Fix broken CI step. **Additional Notes**: HOW CAN YAML BE MORE ANNOYING THAN JSON. **How to test the change?**: Validate that GitLab CI pipeline step runs.
ivoanjo
added a commit
that referenced
this pull request
Jun 28, 2023
**What does this PR do?**: Fix a bug in YAML syntax introduced in #182. **Motivation**: Fix broken CI step. **Additional Notes**: HOW CAN YAML BE MORE ANNOYING THAN JSON. **How to test the change?**: Validate that GitLab CI pipeline step runs.
ivoanjo
added a commit
that referenced
this pull request
Jun 28, 2023
**What does this PR do?**: Fix a bug in YAML syntax introduced in #182. **Motivation**: Fix broken CI step. **Additional Notes**: HOW CAN YAML BE MORE ANNOYING THAN JSON. **How to test the change?**: Validate that GitLab CI pipeline step runs.
ivoanjo
added a commit
that referenced
this pull request
Jun 28, 2023
**What does this PR do?**: Fix a bug in YAML syntax introduced in #182. **Motivation**: Fix broken CI step. **Additional Notes**: HOW CAN YAML BE MORE ANNOYING THAN JSON. **How to test the change?**: Validate that GitLab CI pipeline step runs.
ivoanjo
added a commit
that referenced
this pull request
Jun 28, 2023
**What does this PR do?**: Fix a bug in YAML syntax introduced in #182. **Motivation**: Fix broken CI step. **Additional Notes**: HOW CAN YAML BE MORE ANNOYING THAN JSON. **How to test the change?**: Validate that GitLab CI pipeline step runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Add a tiny message pointing people in the right direction if something fails in GitLab CI.
Motivation:
I got confused by this, so might as well improve it so that I'm the last person to be confused :)
Additional Notes:
N/A
How to test the change?:
Validate that this message shows up when going to the "report_gitlab_CI_status" job in CI.