profiling: fix sample types error message #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrisonlevi
approved these changes
Jun 28, 2023
morrisonlevi
changed the title
realFlowControl
approved these changes
Jun 28, 2023
|
CI is complaining due to #183 |
Will wait for you ;) (no pressure ;) ) |
gleocadie
force-pushed
the
gleocadie/fix-error-message
branch
from
288af88
to
f0881cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the error message which can be misleading when investigating issues.
Motivation
If you create a profile with 2 samples types and add a sample with 3 sample types, you will get this error message:
But, it's not correct, we should have got:
Additional Notes
N/A
How to test the change?
N/A