Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libdatadog to 3.0.0 #187

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Bump libdatadog to 3.0.0 #187

merged 1 commit into from
Jul 3, 2023

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Jul 3, 2023

What does this PR do?:

Bump libdatadog version to 3.0.0 in preparation for release.

Motivation:

Release next version.

Additional Notes:

As we discussed via slack/in the previous weekly meeting, since #181 contains a very small backwards-incompatible change to ddog_prof_Exporter_Request_build, then since we're trying to strictly adhere to semver, I'm bumping the major version of the library.

Nevertheless, upgrading from 2.2.0 to 3.0.0 is really trivial.

How to test the change?:

Validate that CI is still green? Only the version really changes :)

**What does this PR do?**:

Bump libdatadog version to 3.0.0 in preparation for release.

**Motivation**:

Release next version.

**Additional Notes**:

As we discussed via slack/in the previous weekly meeting, since #181
contains a very small backwards-incompatible change to
`ddog_prof_Exporter_Request_build`, then since we're trying to
strictly adhere to semver, I'm bumping the major version of the library.

Nevertheless, upgrading from 2.2.0 to 3.0.0 is really trivial.

**How to test the change?**:

Validate that CI is still green? Only the version really changes :)
@ivoanjo ivoanjo requested a review from a team as a code owner July 3, 2023 13:12
@github-actions github-actions bot added profiling Relates to the profiling* modules. telemetry common labels Jul 3, 2023
@ivoanjo
Copy link
Member Author

ivoanjo commented Jul 3, 2023

Going ahead and merging this. CI is broken due to

Test / Verify trace-protobuf .proto files are in sync with datadog-agent (push)

but the trace-protobuf subcrate is currently only part of serverless mini agent releases, which are not (yet?) included in the libdatadog shared library releases.

I've ping'd folks from serverless to help fix that one.

@ivoanjo ivoanjo merged commit 76654af into main Jul 3, 2023
@bantonsson bantonsson deleted the ivoanjo/bump-to-v3.0.0 branch March 7, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common profiling Relates to the profiling* modules. telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants