style: fix Rust 1.75 lints #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also manually fix up some cfg(test) confusion it got confused by.
github-actions
bot
added
profiling
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
realFlowControl
approved these changes
Jan 8, 2024
danielsn
reviewed
Jan 8, 2024
| @@ -1,7 +1,6 @@ | |||
| // Unless explicitly stated otherwise all files in this repository are licensed under the Apache License Version 2.0. | |||
| // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2023-Present Datadog, Inc. | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
Why did you remove this cfg?
There was a problem hiding this comment.
The includes are guarded by cfg(test) instead. This fixes unused import warnings in non-test. Having both cfgs seemed pointlessly redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a series of lints that now show up due to Rust 1.75's release.
Motivation
I opened a PR for something else and notice the lints failed.
Additional Notes
cargo clippy --fix --libis pretty nice, but I still had to resolve two things by hand.PROF-8862
How to test the change?
Everything should work the same. Locally, all tests still passed.
For Reviewers
@DataDog/security-design-and-guidance.