-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[trace-obfuscation] Add SQL obfuscator and make other obfuscators run faster #362
Merged
paullegranddc
merged 11 commits into
main
from
paullgdc/trace-obfuscation/improve_obfuscation
Mar 19, 2024
Merged
[trace-obfuscation] Add SQL obfuscator and make other obfuscators run faster #362
paullegranddc
merged 11 commits into
main
from
paullgdc/trace-obfuscation/improve_obfuscation
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. My only real comment is about the wiring up and running of the benchmarks, standard documented rust way is not working anymore.
bantonsson
reviewed
Mar 18, 2024
bantonsson
approved these changes
Mar 19, 2024
paullegranddc
deleted the
paullgdc/trace-obfuscation/improve_obfuscation
branch
March 19, 2024 13:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
The changes to the existing redis and tags obfuscators should not affect their semantics as they are still passing the existing tests.
Motivation
An SQL obfuscator is needed to make the stats computation in data-pipeline implementation spec compliant.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.
For Reviewers
@DataDog/security-design-and-guidance
.