Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: clean up profiling deps #372

Merged
merged 2 commits into from
Mar 28, 2024
Merged

build: clean up profiling deps #372

merged 2 commits into from
Mar 28, 2024

Conversation

morrisonlevi
Copy link
Contributor

@morrisonlevi morrisonlevi commented Mar 27, 2024

What does this PR do?

Trims down the dependencies of the profiling/ subdirectory, and updates patch versions of some dependencies as well.

Motivation

The removed deps were added when crashtracking was in this subdir, but it's been moved out and these were left.

Additional Notes

None.

How to test the change?

Everything should work as before without any changes.

For Reviewers

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Most of these were added when crashtracking was in this subdir, but
it's been moved out and these were left.
@morrisonlevi morrisonlevi requested a review from a team as a code owner March 27, 2024 22:48
@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Mar 27, 2024
@morrisonlevi morrisonlevi changed the title build: remove unnecessary profiling deps build: clean up profiling deps Mar 27, 2024
@morrisonlevi
Copy link
Contributor Author

The test failure is:

LLVM ERROR: IO failure on output stream: No space left on device

I've seen someone already ask about this on Slack, so I'll ignore for now.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the great little cleanup :)

@morrisonlevi morrisonlevi merged commit 5aa5ed2 into main Mar 28, 2024
19 of 20 checks passed
@morrisonlevi morrisonlevi deleted the levi/prof-deps-cleanup branch March 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the profiling* modules.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants