Add support for Windows Named Pipe #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleocadie
force-pushed
the
gleocadie/add-named-pipe-support
branch
from
9ea26f3
to
ba663aa
Compare
gleocadie
changed the title
gleocadie
force-pushed
the
gleocadie/add-named-pipe-support
branch
from
ab695b4
to
0a12c7c
Compare
paullegranddc
approved these changes
Aug 24, 2022
| } | ||
|
|
||
| pub type ConnStreamError = Box<dyn std::error::Error + Send + Sync>; | ||
|
|
||
| use hyper::{client::HttpConnector, service::Service}; | ||
| impl ConnStream { | ||
| pub async fn from_uds_uri(uri: hyper::Uri) -> Result<ConnStream, ConnStreamError> { | ||
| pub async fn from_uds_uri(_uri: hyper::Uri) -> Result<ConnStream, ConnStreamError> { |
There was a problem hiding this comment.
Did you put _uri here because of unused warnings when compiling on #[cfg(not(unix))?
If yes, I'd rather put something like
#[cfg(not(unix))]
{
let _ = uri;
Err(super::errors::Error::UnixSocketUnsupported.into())
}Because when I see underscored variables in function signatures, I assume the value will. be unused which is not always the case
There was a problem hiding this comment.
yeah exactly. Sorry for that, I'm a beginner in Rust.
Thanks, I'll fix it
morrisonlevi
approved these changes
Aug 24, 2022
We will put some tests in our hand with named pipe to ensure that it works accordingly (once released) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for the Windows Named Pipe.
Motivation
The .NET tracer currently runs in environment (AAS) where traces are sent to the agent through windows named pipe. The customers that have their apps in that environment are waiting for the profiler to work there too.
Additional Notes
Not on top of my head
How to test the change?
DD_APM_WINDOWS_PIPE_NAMEto\\.\pipe\datadogpipe\mypipeI check the profiler log and I saw the agent url is the named pipe:
[2022-08-23 22:01:41.691 | info | PId: 421300 | TId: 411900] Using agent endpoint windows:\\.\pipe\datadogpipe\mypipeAnd saw in the dashboard my profiles:
