Platform Handle abstraction + connection negotiation code #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
force-pushed
the
pawel/platform_abstraction
branch
2 times, most recently
from
57f8c14
to
2fca4a2
Compare
pawelchcki
force-pushed
the
pawel/platform_abstraction
branch
4 times, most recently
from
58c0e45
to
1e0474a
Compare
pawelchcki
commented
Sep 6, 2022
| expected_scheduled_after - Duration::from_millis(1) < scheduled_in | ||
| && scheduled_in < expected_scheduled_after | ||
| ); | ||
| assert!(expected_scheduled_after - Duration::from_millis(5) < scheduled_in); |
There was a problem hiding this comment.
@paullegranddc I had to up the Delta, as this test was failing intermitently for me on my laptop
There was a problem hiding this comment.
Makes sense. Timing tests are flaky in essence if the clock is not an injected dependency sadly
pawelchcki
force-pushed
the
pawel/platform_abstraction
branch
2 times, most recently
from
0442b10
to
c074d87
Compare
pawelchcki
force-pushed
the
pawel/platform_abstraction
branch
from
81bd913
to
2be105b
Compare
pawelchcki
commented
Oct 6, 2022
pawelchcki
force-pushed
the
pawel/platform_abstraction
branch
from
ed10edb
to
8bbba91
Compare
paullegranddc
approved these changes
Oct 24, 2022
| expected_scheduled_after - Duration::from_millis(1) < scheduled_in | ||
| && scheduled_in < expected_scheduled_after | ||
| ); | ||
| assert!(expected_scheduled_after - Duration::from_millis(5) < scheduled_in); |
There was a problem hiding this comment.
Makes sense. Timing tests are flaky in essence if the clock is not an injected dependency sadly
pawelchcki
force-pushed
the
pawel/platform_abstraction
branch
from
11f2a6c
to
942a0e8
Compare
Includes tools for safe handling of file descriptors, locks and forking a daemon subprocess / sidecar. With the recent stabilization of https://doc.rust-lang.org/std/os/unix/io/struct.OwnedFd.html I've removed some no longer necessary abstractions that basically reimplemented OwnedFd. I've used io-lifetimes crate to backport the implementation to older rust versions. The two biggest parts of this PR that lay groundwork for the IPC mechanism are: PlatformHandle<T> - which allows safe, ref-counted sharing of a FD both within the process and also facilitates transferring it between processes. it can be used across threads to send data through a shared socket without using locks avoiding mutexes is important as the process could be forked (e.g. in PHP) at anytime Liaison trait - which allows IPC to be set up between processes it implements mechanism to establish a shared named socket on the system only one process will take ownership of the listener type on the socket the rest will only connect to it when needed
pawelchcki
force-pushed
the
pawel/platform_abstraction
branch
from
942a0e8
to
7bc812a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR to merge in the IPC work
with basic framework for safe handling of file descriptors both within the process and across processes.
With the recent stabilization of https://doc.rust-lang.org/std/os/unix/io/struct.OwnedFd.html I've removed some no longer necessary abstractions that basically reimplemented OwnedFd. I've used
io-lifetimescrate to backport the implementation to older rust versions.The two biggest parts of this PR that lay groundwork for the IPC mechanism are:
PlatformHandle<T>- which allows safe, ref-counted sharing of a FD both within the process and also facilitates transferring it between processes.Liaisontrait - which allows IPC to be set up between processes