Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo nextest and remove the compile fix #456

Merged
merged 1 commit into from
May 27, 2024

Conversation

gleocadie
Copy link
Contributor

@gleocadie gleocadie commented May 27, 2024

What does this PR do?

The same error was discovered and fixed by in nextest-rs/nextest#1493

Motivation

Remove hack.

Describe here in detail how the change can be validated.

@gleocadie gleocadie force-pushed the gleocadie/update-cargo-next branch from 7b66762 to aabb440 Compare May 27, 2024 11:04
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (347df21) to head (aabb440).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   67.76%   67.76%           
=======================================
  Files         193      193           
  Lines       24476    24476           
=======================================
  Hits        16585    16585           
  Misses       7891     7891           
Components Coverage Δ
crashtracker 19.34% <ø> (ø)
datadog-alloc 98.76% <ø> (ø)
data-pipeline 51.45% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 85.24% <ø> (ø)
ddcommon-ffi 74.93% <ø> (ø)
ddtelemetry 56.09% <ø> (ø)
ipc 81.27% <ø> (ø)
profiling 78.09% <ø> (ø)
profiling-ffi 60.05% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.58% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.12% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.74% <ø> (ø)
trace-protobuf 30.76% <ø> (ø)
trace-utils 78.29% <ø> (ø)

@gleocadie gleocadie changed the title Remove the compile fix for cargo next Update cargo nextest and remove the compile fix May 27, 2024
@gleocadie gleocadie marked this pull request as ready for review May 27, 2024 11:14
@gleocadie gleocadie requested a review from a team as a code owner May 27, 2024 11:14
Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gleocadie gleocadie merged commit 315a093 into main May 27, 2024
26 checks passed
@gleocadie gleocadie deleted the gleocadie/update-cargo-next branch May 27, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants