Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use the <string> header in crashinfo.cpp #472

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Jun 6, 2024

What does this PR do?

Explicitly uses <string> as a header for crashinfo.cpp.

Motivation

Windows CI was failing. https://github.com/DataDog/libdatadog/actions/runs/9402609405/job/25900083549 This looked like it might fix the error

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested a review from a team as a code owner June 6, 2024 15:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.24%. Comparing base (bcc567a) to head (fd2e507).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   69.24%   69.24%           
=======================================
  Files         195      195           
  Lines       26051    26051           
=======================================
  Hits        18039    18039           
  Misses       8012     8012           
Components Coverage Δ
crashtracker 17.62% <ø> (ø)
datadog-alloc 98.76% <ø> (ø)
data-pipeline 51.45% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.43% <ø> (ø)
ddcommon-ffi 74.15% <ø> (ø)
ddtelemetry 56.11% <ø> (ø)
ipc 84.53% <ø> (ø)
profiling 77.83% <ø> (ø)
profiling-ffi 59.61% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.29% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.33% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.74% <ø> (ø)
trace-protobuf 33.33% <ø> (ø)
trace-utils 90.94% <ø> (ø)

@danielsn danielsn merged commit 436c751 into main Jun 6, 2024
27 checks passed
@danielsn danielsn deleted the dsn/fix-windows-ffi branch June 6, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants