-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crashtracker] Add tests for unix socket receiver, and mark slow tests ignore #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
- Coverage 69.62% 69.55% -0.07%
==========================================
Files 199 200 +1
Lines 26633 26656 +23
==========================================
- Hits 18542 18541 -1
- Misses 8091 8115 +24
|
danielsn
commented
Jun 12, 2024
danielsn
changed the title
[crashtracker] Ignore slow release tests
[crashtracker] Add tests for unix socket receiver, and mark slow tests ignore
Jun 13, 2024
taegyunkim
requested changes
Jun 14, 2024
taegyunkim
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ignore
Motivation
Additional Notes
These tests pass a bunch of arguments positionally. This is not ideal, and made them harder to maintain, but since they're tests I felt leaving it that way was OK for now.
How to test the change?
This is a test!