style: fix lints from Rust 1.79 release #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
profiling
morrisonlevi
changed the title
danielsn
approved these changes
Jun 13, 2024
| // Safety: the value is a u64, but pprof only has signed values, so we | ||
| // transmute it; the backend does the same. | ||
| unsafe { std::intrinsics::transmute(id) } | ||
| unsafe { std::intrinsics::transmute::<i64, u64>(*num) } |
morrisonlevi
force-pushed
the
levi/clippy-v1.79
branch
from
a306f3a
to
ed3927c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 69.64% 69.67% +0.03%
==========================================
Files 199 199
Lines 26634 26606 -28
==========================================
- Hits 18549 18539 -10
+ Misses 8085 8067 -18
|
morrisonlevi
force-pushed
the
levi/clippy-v1.79
branch
from
ed3927c
to
7587701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes lints from Rust 1.79 release:
clippy::duplicated_attributesclippy::legacy_numeric_constantsdead_codenow triggers on somerepr(C)FFI structs because fields are never read in Rust.Motivation
A new stable release was made, so CI starts failing.
Additional Notes
Nope.
How to test the change?
Everything should be the same.