Skip serialization of field Span.error if equals to 0 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierotibou
reviewed
Jun 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage ? 69.39%
=======================================
Files ? 201
Lines ? 26745
Branches ? 0
=======================================
Hits ? 18560
Misses ? 8185
Partials ? 0
|
iamluc
force-pushed
the
luc/skip-span-error-serialization-if-default
branch
from
0a23b17
to
75db04e
Compare
Done! |
bantonsson
approved these changes
Jun 24, 2024
iamluc
force-pushed
the
luc/skip-span-error-serialization-if-default
branch
from
75db04e
to
2fd168a
Compare
hoolioh
requested changes
Jun 24, 2024
bwoebi
reviewed
Jun 24, 2024
| @@ -63,6 +63,10 @@ fn generate_protobuf() { | |||
| ".pb.Span.spanLinks", | |||
| "#[serde(skip_serializing_if = \"::prost::alloc::vec::Vec::is_empty\")]", | |||
| ); | |||
| config.field_attribute( | |||
| ".pb.Span.error", | |||
| "#[serde(skip_serializing_if = \"is_default\")]", | |||
There was a problem hiding this comment.
You can use ::std::i32::is_zero instead.
There was a problem hiding this comment.
It fails with
error[E0425]: cannot find function `is_zero` in module `std::i32`
--> libdatadog/trace-protobuf/src/pb.rs:115:35
|
115 | #[serde(skip_serializing_if = "::std::i32::is_zero")]
|
There was a problem hiding this comment.
Hm. Well, try i32::is_zero without the std stuff.
There was a problem hiding this comment.
Same.
At first try, I used is_negative (https://moshg.github.io/rust-std-ja/std/primitive.i32.html#method.is_negative), but it gave me an other error:
error[E0308]: mismatched types
--> trace-protobuf/src/pb.rs:57:23
|
57 | #[derive(Deserialize, Serialize)]
| ^^^^^^^^^ expected `i32`, found `&i32`
...
114 | #[serde(skip_serializing_if = "i32::is_negative")]
| ------------------ arguments to this function are incorrect
2fd168a
to
934db37
Compare
iamluc
force-pushed
the
luc/skip-span-error-serialization-if-default
branch
from
dd150af
to
aa7241c
Compare
iamluc
force-pushed
the
luc/skip-span-error-serialization-if-default
branch
from
021a3bc
to
2f33ff5
Compare
hoolioh
approved these changes
Jun 24, 2024
hoolioh
approved these changes
Jun 24, 2024
duncanpharvey
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Skip serialization of field Span.error if equals to 0 * Add tests * Move serde_json in dev-dependencies * Fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It skips the serialization of the field
Span.errorif the value is 0 as it's done by tracers (at least .net and PHP)Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.