-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APMSP-1229] Implement new origin detection spec #509
Merged
VianneyRuhlmann
merged 2 commits into
main
from
vianney/ddcommon/implement-new-container-origin
Jul 1, 2024
Merged
[APMSP-1229] Implement new origin detection spec #509
VianneyRuhlmann
merged 2 commits into
main
from
vianney/ddcommon/implement-new-container-origin
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VianneyRuhlmann
changed the title
[Container Tagging] Implement new origin detection spec
[APMSP-1229] Implement new origin detection spec
Jun 27, 2024
VianneyRuhlmann
force-pushed
the
vianney/ddcommon/implement-new-container-origin
branch
2 times, most recently
from
June 27, 2024 09:50
0138570
to
49698e0
Compare
BenchmarksComparisonParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Warnings
BaselineBaseline benchmark detailsGroup 1
Warnings
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
=======================================
Coverage 70.37% 70.38%
=======================================
Files 204 204
Lines 27824 27835 +11
=======================================
+ Hits 19581 19591 +10
- Misses 8243 8244 +1
|
VianneyRuhlmann
force-pushed
the
vianney/ddcommon/implement-new-container-origin
branch
from
June 27, 2024 15:40
49698e0
to
c206588
Compare
bantonsson
approved these changes
Jun 28, 2024
wdhif
approved these changes
Jun 28, 2024
VianneyRuhlmann
deleted the
vianney/ddcommon/implement-new-container-origin
branch
July 1, 2024 12:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement the new container origin spec by:
cid
prefix toci
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.