Implement timeouts for both sending traces and telemetry. #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
profiling
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
from
1a8343f
to
e2ca938
Compare
BenchmarksThis comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output. |
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
from
e2ca938
to
c93575a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 70.42% 70.58% +0.16%
==========================================
Files 206 206
Lines 27964 28129 +165
==========================================
+ Hits 19694 19856 +162
- Misses 8270 8273 +3
|
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
from
ca17e83
to
85dc749
Compare
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
from
1ed553b
to
0513e2b
Compare
|
Slightly surprised that we opt modifying the Endpoint struct, but it probably makes sense :-) Can you please also add a FFI API to set the timeout on the Endpoint? |
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
from
0513e2b
to
85dc749
Compare
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
5 times, most recently
from
2efdfd2
to
6f93cd0
Compare
bantonsson
reviewed
Jul 4, 2024
danielsn
reviewed
Jul 9, 2024
danielsn
reviewed
Jul 9, 2024
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
4 times, most recently
from
1a38259
to
18f54cb
Compare
bwoebi
approved these changes
Jul 10, 2024
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
3 times, most recently
from
1265a2f
to
949da71
Compare
danielsn
approved these changes
Jul 16, 2024
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
2 times, most recently
from
0f35bf4
to
253fcb0
Compare
* Lower default timeout value to 3 seconds. * Fix overwriting timeout value from endpoint passed as a parameter. * Rename timeout constant in send data tests.
* Use from_slice in tests. * Fix timeout. * Fix spelling. * Add error handling to set_timeout.
hoolioh
force-pushed
the
julio/APMSP-1235-implement-timeouts
branch
from
253fcb0
to
702cceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new timeout field to the
Endpointstruct in order to set a timeout for outgoing connections used for sending telemetry and traces.Motivation
Prevent situations where holding too many connections could lead to memory pressure or resource exhaustion in the system by dropping them after a period of inactivity.