Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ddsketch] add DDSketch.count() -> f64 to return number of points in the sketch #532

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

brettlangdon
Copy link
Member

What does this PR do?

Adds DDSketch.count() -> f64 function which returns the number of points currently in the sketch.

Motivation

For testing behavior like stats computation or datastreams, being able to assert that the bucketing into sketches works as intended would be helpful.

Additional Notes

How to test the change?

cargo test

@brettlangdon brettlangdon requested review from a team as code owners July 16, 2024 12:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.29%. Comparing base (f380cb5) to head (ae7c810).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   70.21%   70.29%   +0.07%     
==========================================
  Files         206      206              
  Lines       27815    27819       +4     
==========================================
+ Hits        19530    19554      +24     
+ Misses       8285     8265      -20     
Components Coverage Δ
crashtracker 16.86% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 51.15% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.41% <ø> (ø)
ddcommon-ffi 75.31% <ø> (ø)
ddtelemetry 59.02% <ø> (ø)
ipc 84.13% <ø> (ø)
profiling 78.68% <ø> (ø)
profiling-ffi 58.26% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 35.64% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 70.93% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 90.68% <ø> (+0.77%) ⬆️

@pr-commenter
Copy link

pr-commenter bot commented Jul 16, 2024

Benchmarks

This comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output.

@brettlangdon brettlangdon merged commit bfeef6d into main Jul 16, 2024
32 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/ddsketch.count branch July 16, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants