Use the Windows User ID as sidecar identifier instead of the Session ID #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the session identifier is not a good permission boundary and will lead to permission denied for other processes belonging to the same session id, but different security id.
bwoebi
force-pushed
the
bob/sidecar-windows-SID
branch
from
4b8b184
to
be0a850
Compare
bwoebi
force-pushed
the
bob/sidecar-windows-SID
branch
from
be0a850
to
261c5fc
Compare
pawelchcki
approved these changes
Jul 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 70.44% 70.44%
=======================================
Files 213 213
Lines 28455 28455
=======================================
Hits 20044 20044
Misses 8411 8411
|
BenchmarksThis comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids permission conflicts with other processes sharing the same Session ID on Windows.