Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SVLS-5049] It is okay to have a stats payload without stats #567

Merged
merged 2 commits into from
Aug 5, 2024
Merged

[SVLS-5049] It is okay to have a stats payload without stats #567

merged 2 commits into from
Aug 5, 2024

Conversation

apiarian-datadog
Copy link
Contributor

What does this PR do?

Prevents seemingly unnecessary errors if a Serverless stats payload happens to not have any stats.

The payload definition in the go protobuf code seems to indicate that stats are allowed to be empty. And that code (firstService closure) is defensive about this possibility. Furthermore our datadog.trace_agent.receiver.stats_buckets metric has a minimum value of 0 so this apparently does happen and is handled as such by our systems.

Motivation

The serverless agent is generating a bunch of noise when it receives these kinds of "empty" stats payloads from the node tracer.

How to test the change?

Added a unit test to confirm that we are able to create stats payloads with these empty stats objects (and empty stats of stats... our naming is a bit hard to follow). Also checking that this does in fact work with an azure function and that we correctly don't have errors there.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.90826% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.39%. Comparing base (a84d949) to head (069d58d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
+ Coverage   70.23%   70.39%   +0.16%     
==========================================
  Files         214      214              
  Lines       28802    28901      +99     
==========================================
+ Hits        20230    20346     +116     
+ Misses       8572     8555      -17
Components Coverage Δ
crashtracker 21.20% <ø> (+0.05%) ⬆️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 50.00% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.07% <ø> (ø)
ddcommon-ffi 70.20% <ø> (ø)
ddtelemetry 58.95% <ø> (ø)
ipc 84.18% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 34.55% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.87% <ø> (ø)
trace-mini-agent 70.88% <0.00%> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 91.81% <97.02%> (+0.91%) ⬆️

@pr-commenter
Copy link

pr-commenter bot commented Aug 1, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-08-05 13:55:28

Comparing candidate commit 069d58d in PR branch aleksandr.pasechnik/svls-5049-empty-stats-maybe with baseline commit a84d949 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 578.050ns 590.663ns ± 5.664ns 590.174ns ± 3.098ns 593.413ns 599.233ns 612.712ns 615.502ns 4.29% 1.351 4.096 0.96% 0.401ns 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 438.729ns 452.866ns ± 3.312ns 453.694ns ± 0.304ns 453.940ns 454.555ns 455.764ns 460.235ns 1.44% -3.318 10.529 0.73% 0.234ns 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 192.486ns 202.027ns ± 3.481ns 203.297ns ± 2.359ns 204.147ns 206.357ns 209.306ns 219.843ns 8.14% 0.381 3.072 1.72% 0.246ns 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.420ns 44.663ns ± 7.991ns 40.911ns ± 2.693ns 49.523ns 61.503ns 61.763ns 62.225ns 52.10% 1.209 0.095 17.85% 0.565ns 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 62.765ns 69.740ns ± 5.643ns 67.877ns ± 3.151ns 69.726ns 80.022ns 81.357ns 82.177ns 21.07% 0.920 -0.623 8.07% 0.399ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [589.878ns; 591.448ns] or [-0.133%; +0.133%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [452.407ns; 453.325ns] or [-0.101%; +0.101%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [201.544ns; 202.509ns] or [-0.239%; +0.239%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [43.556ns; 45.771ns] or [-2.480%; +2.480%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [68.958ns; 70.522ns] or [-1.121%; +1.121%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.262µs 2.272µs ± 0.005µs 2.271µs ± 0.003µs 2.274µs 2.280µs 2.285µs 2.292µs 0.93% 0.980 1.449 0.21% 0.000µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.271µs; 2.272µs] or [-0.029%; +0.029%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 323.766ns 330.828ns ± 5.172ns 330.232ns ± 1.507ns 331.718ns 337.005ns 359.805ns 371.253ns 12.42% 4.330 27.429 1.56% 0.366ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [330.112ns; 331.545ns] or [-0.217%; +0.217%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.901µs 2.920µs ± 1.798µs 2.741µs ± 0.015µs 2.755µs 2.985µs 4.376µs 23.710µs 765.13% 10.169 105.884 61.42% 0.127µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.671µs; 3.170µs] or [-8.533%; +8.533%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 16.677µs 37.294µs ± 32.322µs 37.067µs ± 3.041µs 39.833µs 50.277µs 65.133µs 465.674µs 1156.29% 11.742 152.949 86.45% 2.286µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [32.815µs; 41.774µs] or [-12.011%; +12.011%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.663µs 1.665µs ± 0.002µs 1.665µs ± 0.001µs 1.666µs 1.667µs 1.669µs 1.673µs 0.52% 1.197 3.208 0.09% 0.000µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.665µs; 1.665µs] or [-0.013%; +0.013%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 280.537ns 281.763ns ± 0.384ns 281.760ns ± 0.089ns 281.846ns 282.040ns 282.319ns 285.569ns 1.35% 5.044 51.230 0.14% 0.027ns 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 33.620ns 34.160ns ± 0.596ns 34.067ns ± 0.168ns 34.246ns 34.816ns 35.128ns 41.214ns 20.98% 8.543 96.572 1.74% 0.042ns 1 200
normalization/normalize_name/normalize_name/good execution_time 21.642ns 21.973ns ± 0.179ns 21.959ns ± 0.082ns 22.036ns 22.279ns 22.714ns 22.814ns 3.89% 1.651 5.678 0.81% 0.013ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [281.709ns; 281.816ns] or [-0.019%; +0.019%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [34.078ns; 34.243ns] or [-0.242%; +0.242%] None None None
normalization/normalize_name/normalize_name/good execution_time [21.948ns; 21.998ns] or [-0.113%; +0.113%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.250ns 3.427ns ± 0.017ns 3.428ns ± 0.001ns 3.429ns 3.431ns 3.433ns 3.452ns 0.67% -9.604 92.859 0.49% 0.001ns 1 200
credit_card/is_card_number/ throughput 289725734.718op/s 291820547.184op/s ± 1511843.997op/s 291673102.878op/s ± 79980.861op/s 291761182.389op/s 291915846.834op/s 292215880.097op/s 307685782.871op/s 5.49% 9.642 93.410 0.52% 106903.514op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 85.378ns 87.226ns ± 0.911ns 87.115ns ± 0.439ns 87.588ns 88.683ns 90.864ns 92.114ns 5.74% 1.609 6.103 1.04% 0.064ns 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10856132.992op/s 11465638.040op/s ± 117865.489op/s 11479054.420op/s ± 57709.155op/s 11532070.518op/s 11643170.434op/s 11683954.002op/s 11712651.268op/s 2.03% -1.444 5.261 1.03% 8334.349op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 80.456ns 82.796ns ± 0.852ns 82.726ns ± 0.505ns 83.273ns 84.122ns 85.489ns 86.313ns 4.34% 0.584 1.794 1.03% 0.060ns 1 200
credit_card/is_card_number/ 378282246310005 throughput 11585697.594op/s 12079075.394op/s ± 123556.871op/s 12088090.089op/s ± 74278.911op/s 12149654.311op/s 12274033.871op/s 12352422.914op/s 12429163.687op/s 2.82% -0.480 1.561 1.02% 8736.790op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.266ns 3.423ns ± 0.016ns 3.424ns ± 0.000ns 3.425ns 3.427ns 3.440ns 3.467ns 1.26% -8.890 84.613 0.46% 0.001ns 1 200
credit_card/is_card_number/37828224631 throughput 288409686.339op/s 292150759.167op/s ± 1408752.473op/s 292046774.107op/s ± 40814.379op/s 292083634.231op/s 292173033.408op/s 293112446.353op/s 306192206.216op/s 4.84% 8.991 85.642 0.48% 99613.843op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 77.453ns 80.128ns ± 0.825ns 80.099ns ± 0.471ns 80.602ns 81.482ns 81.839ns 83.442ns 4.17% -0.017 2.043 1.03% 0.058ns 1 200
credit_card/is_card_number/378282246310005 throughput 11984367.978op/s 12481381.283op/s ± 128557.104op/s 12484589.385op/s ± 73055.354op/s 12549787.792op/s 12678404.018op/s 12888966.731op/s 12911083.367op/s 3.42% 0.141 2.015 1.03% 9090.360op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 66.402ns 68.069ns ± 0.383ns 68.099ns ± 0.182ns 68.246ns 68.635ns 69.019ns 69.937ns 2.70% 0.096 4.049 0.56% 0.027ns 1 200
credit_card/is_card_number/37828224631000521389798 throughput 14298642.588op/s 14691430.614op/s ± 82607.332op/s 14684467.836op/s ± 39046.500op/s 14731902.130op/s 14835046.518op/s 14906960.566op/s 15059756.421op/s 2.56% 0.005 3.955 0.56% 5841.220op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 20.829ns 22.465ns ± 0.455ns 22.434ns ± 0.294ns 22.746ns 23.284ns 23.603ns 23.640ns 5.38% 0.095 0.839 2.02% 0.032ns 1 200
credit_card/is_card_number/x371413321323331 throughput 42301682.435op/s 44531940.460op/s ± 902109.719op/s 44575567.614op/s ± 583915.726op/s 45088195.982op/s 45834643.302op/s 46673077.304op/s 48010121.093op/s 7.71% 0.082 1.006 2.02% 63788.790op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.263ns 3.429ns ± 0.016ns 3.431ns ± 0.001ns 3.431ns 3.433ns 3.436ns 3.454ns 0.67% -9.607 92.173 0.48% 0.001ns 1 200
credit_card/is_card_number_no_luhn/ throughput 289546794.816op/s 291606830.199op/s ± 1468593.737op/s 291482943.713op/s ± 49144.033op/s 291525167.080op/s 291605893.525op/s 291977963.406op/s 306420188.240op/s 5.12% 9.633 92.491 0.50% 103845.259op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 66.729ns 68.000ns ± 0.531ns 67.970ns ± 0.288ns 68.257ns 68.969ns 69.575ns 69.897ns 2.84% 0.706 1.512 0.78% 0.038ns 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14306665.575op/s 14706731.129op/s ± 114258.772op/s 14712460.955op/s ± 62352.360op/s 14774024.577op/s 14874536.238op/s 14955054.272op/s 14985891.884op/s 1.86% -0.636 1.393 0.77% 8079.315op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 62.214ns 63.080ns ± 0.427ns 63.009ns ± 0.241ns 63.323ns 63.743ns 64.207ns 64.894ns 2.99% 0.776 1.140 0.68% 0.030ns 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15409724.793op/s 15853705.448op/s ± 106778.971op/s 15870688.780op/s ± 60818.653op/s 15926302.980op/s 16008477.258op/s 16056560.817op/s 16073522.387op/s 1.28% -0.726 0.989 0.67% 7550.413op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.269ns 3.429ns ± 0.016ns 3.431ns ± 0.001ns 3.431ns 3.432ns 3.434ns 3.439ns 0.23% -9.760 93.868 0.47% 0.001ns 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 290815573.481op/s 291622901.804op/s ± 1432130.637op/s 291488473.356op/s ± 44260.964op/s 291525557.124op/s 291631119.833op/s 291962044.934op/s 305911240.681op/s 4.95% 9.768 93.977 0.49% 101266.929op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 59.601ns 60.619ns ± 0.515ns 60.566ns ± 0.253ns 60.838ns 61.418ns 62.206ns 63.155ns 4.28% 1.299 4.644 0.85% 0.036ns 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15834077.916op/s 16497580.208op/s ± 138719.759op/s 16510992.453op/s ± 69382.950op/s 16579000.658op/s 16709809.356op/s 16777976.026op/s 16778153.259op/s 1.62% -1.176 4.125 0.84% 9808.968op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 67.194ns 67.717ns ± 0.269ns 67.652ns ± 0.064ns 67.747ns 68.210ns 68.880ns 69.202ns 2.29% 2.650 9.272 0.40% 0.019ns 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 14450367.029op/s 14767544.707op/s ± 57996.244op/s 14781595.865op/s ± 13977.172op/s 14793551.664op/s 14822642.605op/s 14851049.158op/s 14882293.424op/s 0.68% -2.600 8.965 0.39% 4100.954op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 21.263ns 22.259ns ± 0.410ns 22.249ns ± 0.213ns 22.442ns 22.934ns 23.616ns 23.797ns 6.96% 0.699 2.119 1.84% 0.029ns 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 42021916.167op/s 44941597.353op/s ± 819674.703op/s 44944907.136op/s ± 430196.485op/s 45377559.089op/s 46180605.628op/s 46968559.355op/s 47029726.704op/s 4.64% -0.504 1.751 1.82% 57959.754op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.425ns; 3.429ns] or [-0.068%; +0.068%] None None None
credit_card/is_card_number/ throughput [291611020.146op/s; 292030074.222op/s] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [87.100ns; 87.353ns] or [-0.145%; +0.145%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [11449303.017op/s; 11481973.063op/s] or [-0.142%; +0.142%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [82.678ns; 82.914ns] or [-0.143%; +0.143%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12061951.600op/s; 12096199.188op/s] or [-0.142%; +0.142%] None None None
credit_card/is_card_number/37828224631 execution_time [3.421ns; 3.425ns] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/37828224631 throughput [291955519.623op/s; 292345998.711op/s] or [-0.067%; +0.067%] None None None
credit_card/is_card_number/378282246310005 execution_time [80.014ns; 80.242ns] or [-0.143%; +0.143%] None None None
credit_card/is_card_number/378282246310005 throughput [12463564.505op/s; 12499198.062op/s] or [-0.143%; +0.143%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [68.016ns; 68.122ns] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [14679982.032op/s; 14702879.195op/s] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/x371413321323331 execution_time [22.402ns; 22.528ns] or [-0.281%; +0.281%] None None None
credit_card/is_card_number/x371413321323331 throughput [44406916.730op/s; 44656964.191op/s] or [-0.281%; +0.281%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.427ns; 3.432ns] or [-0.067%; +0.067%] None None None
credit_card/is_card_number_no_luhn/ throughput [291403297.231op/s; 291810363.167op/s] or [-0.070%; +0.070%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [67.927ns; 68.074ns] or [-0.108%; +0.108%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14690895.962op/s; 14722566.296op/s] or [-0.108%; +0.108%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [63.020ns; 63.139ns] or [-0.094%; +0.094%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15838906.909op/s; 15868503.986op/s] or [-0.093%; +0.093%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.427ns; 3.431ns] or [-0.065%; +0.065%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [291424422.272op/s; 291821381.337op/s] or [-0.068%; +0.068%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [60.548ns; 60.691ns] or [-0.118%; +0.118%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16478354.984op/s; 16516805.432op/s] or [-0.117%; +0.117%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [67.680ns; 67.754ns] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [14759506.985op/s; 14775582.429op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [22.202ns; 22.315ns] or [-0.256%; +0.256%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [44827998.323op/s; 45055196.384op/s] or [-0.253%; +0.253%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.890µs 36.974µs ± 0.081µs 36.968µs ± 0.023µs 36.990µs 37.013µs 37.083µs 37.920µs 2.58% 8.848 95.708 0.22% 0.006µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [36.963µs; 36.985µs] or [-0.030%; +0.030%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 137.451µs 137.805µs ± 0.202µs 137.787µs ± 0.069µs 137.855µs 138.095µs 138.336µs 139.373µs 1.15% 3.792 24.663 0.15% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [137.777µs; 137.833µs] or [-0.020%; +0.020%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 069d58d 1722865237 aleksandr.pasechnik/svls-5049-empty-stats-maybe
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 70.586µs 70.824µs ± 0.085µs 70.821µs ± 0.027µs 70.843µs 70.896µs 71.025µs 71.766µs 1.33% 6.839 74.028 0.12% 0.006µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [70.812µs; 70.835µs] or [-0.017%; +0.017%] None None None

Baseline

Omitted due to size.

@apiarian-datadog
Copy link
Contributor Author

Before this change the agent had the following errors logged:

2024-08-02T16:56:55Z   [Information]   [2024-08-02T16:56:55Z INFO  datadog_trace_mini_agent::stats_processor] Recieved trace stats to process
2024-08-02T16:56:55Z   [Information]   [2024-08-02T16:56:55Z ERROR datadog_trace_mini_agent::http_utils] Error deserializing trace stats from request body: No stats in stats payload

With this change the agent shows the following:

2024-08-02T16:53:06Z   [Information]   [2024-08-02T16:53:05Z INFO  datadog_trace_mini_agent::stats_processor] Recieved trace stats to process
2024-08-02T16:53:06Z   [Information]   [2024-08-02T16:53:05Z INFO  datadog_trace_mini_agent::http_utils] Successfully buffered stats to be flushed.
2024-08-02T16:53:08Z   [Information]   [2024-08-02T16:53:07Z INFO  datadog_trace_mini_agent::stats_flusher] Flushing 1 stats
2024-08-02T16:53:08Z   [Information]   [2024-08-02T16:53:07Z INFO  datadog_trace_mini_agent::stats_flusher] Successfully flushed stats

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5049-empty-stats-maybe branch from cd271c8 to fdb470e Compare August 2, 2024 18:21
@apiarian-datadog apiarian-datadog marked this pull request as ready for review August 2, 2024 18:54
@apiarian-datadog apiarian-datadog requested review from a team as code owners August 2, 2024 18:54
duncanpharvey
duncanpharvey approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@duncanpharvey duncanpharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5049-empty-stats-maybe branch from fdb470e to 069d58d Compare August 5, 2024 13:40
@apiarian-datadog apiarian-datadog merged commit d0832ff into main Aug 5, 2024
43 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/svls-5049-empty-stats-maybe branch August 5, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanpharvey duncanpharvey duncanpharvey approved these changes

Assignees
No one assigned
Labels
mini-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apiarian-datadog @codecov-commenter @duncanpharvey