Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error check in trampoline.c #569

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Fix error check in trampoline.c #569

merged 1 commit into from
Aug 3, 2024

Conversation

cataphract
Copy link
Contributor

@cataphract cataphract commented Aug 2, 2024

The appsec helper library has a call to dlopen() during constructors that may fail. Without clearing it, a call to dlerror() after a successful call to dlsym() will return the previous error message.

man 3 dlsym() says:

The correct way to distinguish an error from a symbol whose value is NULL is to
call dlerror(3) to clear any old error conditions, then call dlsym(), and then call dlerror(3) again, saving its
return value into a variable, and check whether this saved value is not NULL.

@cataphract cataphract requested a review from a team as a code owner August 2, 2024 11:56
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (39cf158) to head (ce67e3c).
Report is 108 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files         214      214           
  Lines       28785    28785           
=======================================
  Hits        20231    20231           
  Misses       8554     8554           
Components Coverage Δ
crashtracker 21.20% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 50.00% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.07% <ø> (ø)
ddcommon-ffi 70.20% <ø> (ø)
ddtelemetry 58.95% <ø> (ø)
ipc 84.18% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 34.55% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.87% <ø> (ø)
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 91.49% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Aug 2, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-08-02 12:14:25

Comparing candidate commit ce14840 in PR branch glopes/fix-trampoline with baseline commit cc8ed56 in branch main.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics.

scenario:normalization/normalize_trace/test_trace

  • 🟩 execution_time [-13.201ns; -10.518ns] or [-2.725%; -2.171%]

scenario:tags/replace_trace_tags

  • 🟥 execution_time [+165.003ns; +169.461ns] or [+3.832%; +3.936%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 188.360µs 188.833µs ± 0.214µs 188.819µs ± 0.126µs 188.944µs 189.255µs 189.402µs 189.599µs 0.41% 0.600 0.662 0.11% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [188.804µs; 188.863µs] or [-0.016%; +0.016%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 105.959µs 106.179µs ± 0.077µs 106.168µs ± 0.036µs 106.212µs 106.277µs 106.330µs 106.830µs 0.62% 3.503 25.805 0.07% 0.005µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [106.168µs; 106.190µs] or [-0.010%; +0.010%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 4.439µs 4.473µs ± 0.014µs 4.474µs ± 0.010µs 4.483µs 4.493µs 4.498µs 4.502µs 0.64% -0.144 -0.702 0.30% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [4.471µs; 4.475µs] or [-0.042%; +0.042%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 620.161ns 623.224ns ± 2.925ns 622.077ns ± 1.217ns 625.888ns 627.500ns 632.217ns 640.414ns 2.95% 1.983 6.801 0.47% 0.207ns 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 574.229ns 588.331ns ± 4.288ns 588.500ns ± 2.477ns 590.969ns 595.499ns 599.069ns 601.890ns 2.28% 0.146 0.553 0.73% 0.303ns 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 225.898ns 238.805ns ± 9.692ns 246.174ns ± 0.635ns 246.642ns 246.966ns 247.319ns 247.506ns 0.54% -0.451 -1.791 4.05% 0.685ns 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 91.906ns 108.277ns ± 14.023ns 103.586ns ± 8.880ns 127.503ns 128.037ns 128.196ns 128.471ns 24.02% 0.529 -1.456 12.92% 0.992ns 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 92.247ns 106.695ns ± 13.616ns 100.322ns ± 7.582ns 123.986ns 125.256ns 125.838ns 126.905ns 26.50% 0.454 -1.610 12.73% 0.963ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [622.819ns; 623.630ns] or [-0.065%; +0.065%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [587.737ns; 588.925ns] or [-0.101%; +0.101%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [237.462ns; 240.148ns] or [-0.562%; +0.562%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [106.333ns; 110.220ns] or [-1.795%; +1.795%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [104.808ns; 108.582ns] or [-1.769%; +1.769%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 6.800ns 6.900ns ± 0.102ns 6.871ns ± 0.062ns 6.945ns 7.127ns 7.209ns 7.234ns 5.29% 1.423 1.711 1.48% 0.007ns 1 200
credit_card/is_card_number/ throughput 138226709.120op/s 144960121.118op/s ± 2110051.767op/s 145537886.298op/s ± 1315088.515op/s 146820614.043op/s 146903616.544op/s 146940909.631op/s 147055091.108op/s 1.04% -1.350 1.455 1.45% 149203.191op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 126.491ns 127.944ns ± 0.561ns 127.979ns ± 0.293ns 128.220ns 128.726ns 129.525ns 130.698ns 2.12% 0.574 2.763 0.44% 0.040ns 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 7651223.842op/s 7816061.924op/s ± 34209.308op/s 7813793.105op/s ± 17953.033op/s 7837042.256op/s 7867345.541op/s 7899977.513op/s 7905684.854op/s 1.18% -0.517 2.574 0.44% 2418.963op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 120.698ns 122.809ns ± 0.768ns 122.931ns ± 0.511ns 123.382ns 123.901ns 124.137ns 124.255ns 1.08% -0.525 -0.278 0.62% 0.054ns 1 200
credit_card/is_card_number/ 378282246310005 throughput 8047994.445op/s 8143075.876op/s ± 51089.080op/s 8134640.497op/s ± 33652.168op/s 8171780.956op/s 8245382.081op/s 8266470.468op/s 8285174.199op/s 1.85% 0.552 -0.243 0.63% 3612.543op/s 1 200
credit_card/is_card_number/37828224631 execution_time 6.800ns 6.915ns ± 0.112ns 6.885ns ± 0.074ns 6.959ns 7.200ns 7.214ns 7.217ns 4.83% 1.258 0.896 1.62% 0.008ns 1 200
credit_card/is_card_number/37828224631 throughput 138559205.711op/s 144656125.626op/s ± 2300595.759op/s 145246530.100op/s ± 1564005.440op/s 146814233.932op/s 146901164.295op/s 147021565.054op/s 147050838.502op/s 1.24% -1.196 0.728 1.59% 162676.686op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 118.133ns 120.107ns ± 0.727ns 120.081ns ± 0.404ns 120.526ns 121.320ns 121.379ns 121.900ns 1.51% -0.332 0.316 0.60% 0.051ns 1 200
credit_card/is_card_number/378282246310005 throughput 8203468.337op/s 8326194.950op/s ± 50485.674op/s 8327708.813op/s ± 27992.019op/s 8350175.266op/s 8420262.076op/s 8459680.496op/s 8465033.162op/s 1.65% 0.373 0.361 0.60% 3569.876op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 106.176ns 108.212ns ± 0.509ns 108.405ns ± 0.177ns 108.549ns 108.634ns 108.723ns 109.147ns 0.68% -1.920 3.983 0.47% 0.036ns 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9161930.544op/s 9241353.898op/s ± 43844.840op/s 9224681.237op/s ± 15060.800op/s 9258568.247op/s 9336949.293op/s 9413244.767op/s 9418359.789op/s 2.10% 1.953 4.133 0.47% 3100.298op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 61.074ns 62.991ns ± 0.763ns 63.212ns ± 0.426ns 63.615ns 63.774ns 63.855ns 63.959ns 1.18% -0.990 -0.215 1.21% 0.054ns 1 200
credit_card/is_card_number/x371413321323331 throughput 15634912.725op/s 15877505.003op/s ± 194609.979op/s 15819681.613op/s ± 105964.366op/s 15968991.181op/s 16313104.105op/s 16318237.010op/s 16373655.845op/s 3.50% 1.020 -0.153 1.22% 13761.004op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 6.885ns 7.295ns ± 0.107ns 7.271ns ± 0.061ns 7.329ns 7.591ns 7.610ns 7.616ns 4.75% 1.175 2.547 1.47% 0.008ns 1 200
credit_card/is_card_number_no_luhn/ throughput 131295279.364op/s 137111300.027op/s ± 1983692.542op/s 137535999.686op/s ± 1156321.155op/s 138696348.016op/s 138739762.204op/s 138849498.186op/s 145234924.133op/s 5.60% -1.029 2.597 1.44% 140268.245op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 107.777ns 109.704ns ± 0.741ns 109.730ns ± 0.381ns 110.111ns 110.742ns 111.845ns 113.065ns 3.04% 0.310 2.533 0.67% 0.052ns 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 8844441.763op/s 9115851.662op/s ± 61502.648op/s 9113254.730op/s ± 31552.088op/s 9144345.922op/s 9235859.152op/s 9261856.852op/s 9278441.033op/s 1.81% -0.222 2.328 0.67% 4348.894op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 103.315ns 104.948ns ± 0.514ns 104.923ns ± 0.376ns 105.344ns 105.757ns 105.927ns 105.962ns 0.99% -0.322 0.022 0.49% 0.036ns 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 9437353.051op/s 9528743.127op/s ± 46731.712op/s 9530779.606op/s ± 34171.161op/s 9562727.362op/s 9604927.841op/s 9658371.004op/s 9679132.960op/s 1.56% 0.350 0.071 0.49% 3304.431op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 7.200ns 7.275ns ± 0.074ns 7.258ns ± 0.048ns 7.315ns 7.407ns 7.491ns 7.612ns 4.89% 1.207 1.682 1.01% 0.005ns 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 131362915.215op/s 137478915.037op/s ± 1374197.577op/s 137788200.244op/s ± 920313.404op/s 138701909.628op/s 138757639.395op/s 138881463.896op/s 138885617.159op/s 0.80% -1.143 1.363 1.00% 97170.443op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 100.304ns 102.196ns ± 0.601ns 102.141ns ± 0.349ns 102.601ns 103.217ns 103.474ns 103.491ns 1.32% -0.182 0.513 0.59% 0.042ns 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 9662656.153op/s 9785413.167op/s ± 57617.811op/s 9790412.736op/s ± 33374.015op/s 9819107.128op/s 9867345.645op/s 9957981.152op/s 9969689.898op/s 1.83% 0.226 0.584 0.59% 4074.194op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 107.240ns 108.739ns ± 0.416ns 108.839ns ± 0.120ns 108.946ns 109.304ns 109.385ns 110.170ns 1.22% -1.229 2.991 0.38% 0.029ns 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9076859.009op/s 9196499.686op/s ± 35349.052op/s 9187868.071op/s ± 10123.714op/s 9210096.552op/s 9281418.062op/s 9318690.834op/s 9324866.196op/s 1.49% 1.269 3.045 0.38% 2499.555op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 61.913ns 63.474ns ± 0.519ns 63.515ns ± 0.321ns 63.835ns 64.234ns 64.530ns 64.618ns 1.74% -0.621 0.413 0.82% 0.037ns 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 15475532.170op/s 15755520.125op/s ± 129447.973op/s 15744392.085op/s ± 79106.119op/s 15822464.207op/s 15999403.259op/s 16112905.790op/s 16151800.104op/s 2.59% 0.671 0.493 0.82% 9153.354op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [6.886ns; 6.914ns] or [-0.206%; +0.206%] None None None
credit_card/is_card_number/ throughput [144667688.237op/s; 145252553.999op/s] or [-0.202%; +0.202%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [127.866ns; 128.022ns] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [7811320.843op/s; 7820803.005op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [122.702ns; 122.915ns] or [-0.087%; +0.087%] None None None
credit_card/is_card_number/ 378282246310005 throughput [8135995.421op/s; 8150156.331op/s] or [-0.087%; +0.087%] None None None
credit_card/is_card_number/37828224631 execution_time [6.899ns; 6.930ns] or [-0.225%; +0.225%] None None None
credit_card/is_card_number/37828224631 throughput [144337285.179op/s; 144974966.072op/s] or [-0.220%; +0.220%] None None None
credit_card/is_card_number/378282246310005 execution_time [120.007ns; 120.208ns] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/378282246310005 throughput [8319198.122op/s; 8333191.779op/s] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [108.141ns; 108.282ns] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9235277.425op/s; 9247430.372op/s] or [-0.066%; +0.066%] None None None
credit_card/is_card_number/x371413321323331 execution_time [62.886ns; 63.097ns] or [-0.168%; +0.168%] None None None
credit_card/is_card_number/x371413321323331 throughput [15850533.932op/s; 15904476.075op/s] or [-0.170%; +0.170%] None None None
credit_card/is_card_number_no_luhn/ execution_time [7.280ns; 7.310ns] or [-0.204%; +0.204%] None None None
credit_card/is_card_number_no_luhn/ throughput [136836379.319op/s; 137386220.736op/s] or [-0.201%; +0.201%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [109.601ns; 109.807ns] or [-0.094%; +0.094%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [9107327.986op/s; 9124375.337op/s] or [-0.094%; +0.094%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [104.877ns; 105.019ns] or [-0.068%; +0.068%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [9522266.561op/s; 9535219.693op/s] or [-0.068%; +0.068%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [7.264ns; 7.285ns] or [-0.140%; +0.140%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [137288464.469op/s; 137669365.604op/s] or [-0.139%; +0.139%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [102.113ns; 102.280ns] or [-0.082%; +0.082%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [9777427.893op/s; 9793398.441op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [108.681ns; 108.796ns] or [-0.053%; +0.053%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9191600.647op/s; 9201398.725op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [63.402ns; 63.546ns] or [-0.113%; +0.113%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [15737579.881op/s; 15773460.369op/s] or [-0.114%; +0.114%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 3.157µs 4.215µs ± 3.379µs 3.922µs ± 0.015µs 3.936µs 3.983µs 5.637µs 45.554µs 1061.58% 10.816 121.043 79.96% 0.239µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.747µs; 4.683µs] or [-11.109%; +11.109%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 466.944ns 472.543ns ± 5.457ns 472.044ns ± 1.162ns 473.134ns 476.203ns 481.465ns 541.655ns 14.75% 10.345 127.293 1.15% 0.386ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [471.787ns; 473.300ns] or [-0.160%; +0.160%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 31.007µs 55.720µs ± 17.880µs 55.988µs ± 1.800µs 57.907µs 69.833µs 85.998µs 245.462µs 338.42% 5.955 62.216 32.01% 1.264µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [53.242µs; 58.198µs] or [-4.447%; +4.447%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 3.633µs 3.659µs ± 0.008µs 3.658µs ± 0.004µs 3.662µs 3.672µs 3.690µs 3.695µs 1.03% 0.953 4.072 0.23% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [3.657µs; 3.660µs] or [-0.032%; +0.032%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 65.372µs 65.581µs ± 0.066µs 65.580µs ± 0.027µs 65.609µs 65.645µs 65.728µs 66.243µs 1.01% 4.899 49.747 0.10% 0.005µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [65.572µs; 65.590µs] or [-0.014%; +0.014%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz ce14840 1722599819 glopes/fix-trampoline
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 289.784ns 291.832ns ± 0.696ns 291.935ns ± 0.441ns 292.273ns 292.708ns 293.030ns 295.545ns 1.24% 0.252 3.315 0.24% 0.049ns 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 46.931ns 47.789ns ± 0.221ns 47.811ns ± 0.147ns 47.960ns 48.062ns 48.158ns 48.235ns 0.89% -0.804 0.559 0.46% 0.016ns 1 200
normalization/normalize_name/normalize_name/good execution_time 33.467ns 34.324ns ± 0.685ns 34.228ns ± 0.185ns 34.481ns 34.819ns 35.231ns 42.705ns 24.77% 9.214 110.417 1.99% 0.048ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [291.736ns; 291.929ns] or [-0.033%; +0.033%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [47.758ns; 47.819ns] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/good execution_time [34.229ns; 34.419ns] or [-0.277%; +0.277%] None None None

Baseline

Omitted due to size.

Copy link
Contributor

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The appsec helper library calls a dlopen during during constructors that
may fail. Without clearing it, a call to dlerror() after a successful
call to dlsym() will return the previous error message.
@cataphract cataphract merged commit 866b79d into main Aug 3, 2024
33 checks passed
@cataphract cataphract deleted the glopes/fix-trampoline branch August 3, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants