-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error check in trampoline.c #569
Conversation
37c6b32
to
ce14840
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
=======================================
Coverage 70.28% 70.28%
=======================================
Files 214 214
Lines 28785 28785
=======================================
Hits 20231 20231
Misses 8554 8554
|
BenchmarksComparisonBenchmark execution time: 2024-08-02 12:14:25 Comparing candidate commit ce14840 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics. scenario:normalization/normalize_trace/test_trace
scenario:tags/replace_trace_tags
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
BaselineOmitted due to size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The appsec helper library calls a dlopen during during constructors that may fail. Without clearing it, a call to dlerror() after a successful call to dlsym() will return the previous error message.
ce14840
to
ce67e3c
Compare
The appsec helper library has a call to dlopen() during constructors that may fail. Without clearing it, a call to dlerror() after a successful call to dlsym() will return the previous error message.
man 3 dlsym() says: