ekump/eval bench perf for io read impl #636

…locString

Bytes itself is already a structure with a slice into some underlying bytes. Thus, we are adding a cheap way to directly modify the slice of the Bytes struct. To facilitate this, we now store the tuple (ptr, len) as a &[] slice within the Bytes struct. The representation of these is exactly identical to before, but it allows trivial manipulation of the slice via direct assignment or &mut &[u8] reference. The way the underlying field was exposed on the BytesWrapper struct was also unsound. Access to it was not wrapped within an unsafe method. The decoder code can now trivially clone() the given Bytes struct and carry it around, directly shrinking the slice size of the underlying Bytes instance as the data is being processed. Additionally, there now exist two helper methods for numbers and strings (read_string_bytes and read_number_bytes) which handle a bit of the boilerplate. Sadly it is necessary to always write "unsafe { buf.as_mut_slice() }", but this is necessary for soundness, we only can actually guarantee safety when calling the actual decode functions, as long as we want to carry Bytes around. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

…y for tinybytes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ekump/eval bench perf for io read impl #636

ekump/eval bench perf for io read impl #636

Commits on Sep 17, 2024