Allow setting cgroup path for integration testing purposes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
commented
Oct 17, 2022
r1viollet
reviewed
Oct 17, 2022
ivoanjo
reviewed
Oct 17, 2022
r1viollet
reviewed
Oct 18, 2022
…group_path_for_integration_testing
r1viollet
approved these changes
Oct 19, 2022
|
Thanks for the review ! 🙇 |
pawelchcki
deleted the
pawel/allow_setting_cgroup_path_for_integration_testing
branch
| # LTO is ignored if "lib" is added as crate type | ||
| # cf. https://github.com/rust-lang/rust/issues/51009 | ||
| crate-type = ["staticlib", "cdylib"] | ||
| crate-type = ["lib", "staticlib", "cdylib"] |
There was a problem hiding this comment.
Reminder, this will break your LTO and bloat binary size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently Cgroup path is rightfully hardcoded in the source, however this makes it impossible to perform end-to-end tests on stubbed values of the file, as
/proc/groups/selffile is not overridable on linux systemsMotivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.