-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leaking sessions #642
Fix leaking sessions #642
Conversation
There was async access happening to sessions, causing sessions being re-created after them being destroyed (and with default config, too). Moving get_app() around, into the flushing logic to cleanly separate session access from async context. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 73.05% 73.07% +0.02%
==========================================
Files 252 252
Lines 36093 36072 -21
==========================================
- Hits 26366 26358 -8
+ Misses 9727 9714 -13
|
BenchmarksComparisonBenchmark execution time: 2024-09-19 12:37:04 Comparing candidate commit a991f56 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics. scenario:normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
There was async access happening to sessions, causing sessions being re-created after them being destroyed (and with default config, too).
Moving get_app() around, into the flushing logic to cleanly separate session access from async context.