Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaking sessions #642

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix leaking sessions #642

merged 1 commit into from
Sep 19, 2024

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Sep 19, 2024

There was async access happening to sessions, causing sessions being re-created after them being destroyed (and with default config, too).

Moving get_app() around, into the flushing logic to cleanly separate session access from async context.

There was async access happening to sessions, causing sessions being re-created after them being destroyed (and with default config, too).

Moving get_app() around, into the flushing logic to cleanly separate session access from async context.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested review from a team as code owners September 19, 2024 12:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 69 lines in your changes missing coverage. Please review.

Project coverage is 73.07%. Comparing base (89f48d4) to head (a991f56).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
+ Coverage   73.05%   73.07%   +0.02%     
==========================================
  Files         252      252              
  Lines       36093    36072      -21     
==========================================
- Hits        26366    26358       -8     
+ Misses       9727     9714      -13     
Components Coverage Δ
crashtracker 20.48% <ø> (-0.06%) ⬇️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.12% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ipc 83.63% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.16% <0.00%> (+0.03%) ⬆️
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 91.66% <ø> (ø)
trace-mini-agent 72.49% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.30% <ø> (+0.41%) ⬆️

@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-09-19 12:37:04

Comparing candidate commit a991f56 in PR branch bob/fix-sessions-leak with baseline commit 89f48d4 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics.

scenario:normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて

  • 🟩 execution_time [-19.415µs; -19.282µs] or [-3.997%; -3.970%]
  • 🟩 throughput [+85124.894op/s; +85725.441op/s] or [+4.134%; +4.164%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.939ms 8.961ms ± 0.011ms 8.960ms ± 0.007ms 8.968ms 8.982ms 8.990ms 9.000ms 0.44% 0.619 0.272 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.960ms; 8.963ms] or [-0.018%; +0.018%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 76.221µs 76.395µs ± 0.163µs 76.375µs ± 0.026µs 76.402µs 76.486µs 76.695µs 78.445µs 2.71% 10.405 125.389 0.21% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [76.373µs; 76.418µs] or [-0.030%; +0.030%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.645µs 2.702µs ± 0.020µs 2.701µs ± 0.007µs 2.710µs 2.743µs 2.749µs 2.753µs 1.91% -0.483 2.573 0.73% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.700µs; 2.705µs] or [-0.101%; +0.101%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.042µs 38.679µs ± 1.184µs 38.144µs ± 0.038µs 38.192µs 41.196µs 41.245µs 42.766µs 12.12% 1.747 1.197 3.05% 0.084µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.515µs; 38.843µs] or [-0.424%; +0.424%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 270.399µs 274.155µs ± 1.712µs 274.066µs ± 1.201µs 275.422µs 277.072µs 277.744µs 278.119µs 1.48% 0.136 -0.632 0.62% 0.121µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3595582.324op/s 3647719.513op/s ± 22765.428op/s 3648750.380op/s ± 15992.829op/s 3664099.649op/s 3683125.943op/s 3695858.117op/s 3698232.146op/s 1.36% -0.110 -0.635 0.62% 1609.759op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 25.766µs 25.811µs ± 0.028µs 25.817µs ± 0.011µs 25.826µs 25.847µs 25.896µs 25.919µs 0.40% 0.485 1.086 0.11% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 38581552.849op/s 38743266.679op/s ± 42452.415op/s 38734599.114op/s ± 16687.980op/s 38785859.883op/s 38804639.908op/s 38809396.120op/s 38810352.845op/s 0.20% -0.476 1.059 0.11% 3001.839op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.318µs 15.364µs ± 0.031µs 15.364µs ± 0.022µs 15.381µs 15.413µs 15.445µs 15.578µs 1.39% 1.992 10.126 0.20% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 64193267.432op/s 65087093.769op/s ± 131753.398op/s 65087468.183op/s ± 91494.934op/s 65189705.503op/s 65250137.803op/s 65278538.101op/s 65284516.007op/s 0.30% -1.943 9.714 0.20% 9316.372op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [273.917µs; 274.392µs] or [-0.087%; +0.087%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3644564.444op/s; 3650874.583op/s] or [-0.086%; +0.086%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [25.807µs; 25.815µs] or [-0.015%; +0.015%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [38737383.182op/s; 38749150.175op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.360µs; 15.368µs] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/good throughput [65068834.015op/s; 65105353.522op/s] or [-0.028%; +0.028%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 506.752µs 508.209µs ± 1.212µs 507.722µs ± 0.364µs 508.893µs 510.731µs 511.854µs 513.657µs 1.17% 1.602 2.331 0.24% 0.086µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1946825.329op/s 1967706.345op/s ± 4673.914op/s 1969581.894op/s ± 1412.032op/s 1970686.559op/s 1971839.876op/s 1972673.323op/s 1973350.024op/s 0.19% -1.589 2.266 0.24% 330.496op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 465.543µs 466.345µs ± 0.411µs 466.315µs ± 0.268µs 466.587µs 466.991µs 467.391µs 467.974µs 0.36% 0.576 0.721 0.09% 0.029µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2136871.092op/s 2144334.561op/s ± 1889.059op/s 2144472.431op/s ± 1233.918op/s 2145590.514op/s 2147097.382op/s 2147845.177op/s 2148029.776op/s 0.17% -0.569 0.705 0.09% 133.577op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.766µs 180.364µs ± 0.331µs 180.322µs ± 0.212µs 180.545µs 180.893µs 181.466µs 181.652µs 0.74% 1.030 1.669 0.18% 0.023µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5505045.643op/s 5544352.268op/s ± 10146.771op/s 5545642.157op/s ± 6523.267op/s 5551951.677op/s 5557522.231op/s 5558955.112op/s 5562781.896op/s 0.31% -1.015 1.619 0.18% 717.485op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 43.473µs 43.700µs ± 0.089µs 43.690µs ± 0.060µs 43.760µs 43.855µs 43.919µs 44.021µs 0.76% 0.437 0.223 0.20% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22716571.532op/s 22883629.500op/s ± 46690.825op/s 22888745.332op/s ± 31185.881op/s 22916350.839op/s 22958663.547op/s 22967738.267op/s 23002986.849op/s 0.50% -0.424 0.203 0.20% 3301.540op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.982µs 50.199µs ± 0.122µs 50.178µs ± 0.104µs 50.309µs 50.401µs 50.422µs 50.491µs 0.62% 0.285 -1.097 0.24% 0.009µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19805327.449op/s 19920739.714op/s ± 48244.258op/s 19929089.519op/s ± 41291.630op/s 19960352.010op/s 19987178.458op/s 19994159.344op/s 20007156.048op/s 0.39% -0.279 -1.101 0.24% 3411.384op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [508.041µs; 508.377µs] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1967058.585op/s; 1968354.105op/s] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [466.289µs; 466.402µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2144072.756op/s; 2144596.367op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.318µs; 180.410µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5542946.023op/s; 5545758.513op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [43.687µs; 43.712µs] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22877158.600op/s; 22890100.399op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.182µs; 50.216µs] or [-0.034%; +0.034%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19914053.524op/s; 19927425.904op/s] or [-0.034%; +0.034%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.360µs 3.208µs ± 1.393µs 3.075µs ± 0.023µs 3.095µs 3.179µs 13.808µs 14.890µs 384.29% 7.624 58.402 43.33% 0.099µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.015µs; 3.401µs] or [-6.021%; +6.021%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.208µs 1.208µs ± 0.001µs 1.208µs ± 0.000µs 1.209µs 1.209µs 1.210µs 1.214µs 0.49% 4.967 42.782 0.05% 0.000µs 1 200
credit_card/is_card_number/ throughput 823480790.031op/s 827479251.900op/s ± 415050.936op/s 827525593.871op/s ± 216764.635op/s 827741985.463op/s 827868064.394op/s 827914688.470op/s 827943436.587op/s 0.05% -4.936 42.386 0.05% 29348.533op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 109.320µs 111.089µs ± 0.703µs 111.102µs ± 0.405µs 111.495µs 112.128µs 113.388µs 114.098µs 2.70% 0.592 2.501 0.63% 0.050µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8764388.692op/s 9002175.839op/s ± 56797.094op/s 9000756.064op/s ± 32710.991op/s 9034412.101op/s 9096689.773op/s 9124866.418op/s 9147440.272op/s 1.63% -0.515 2.285 0.63% 4016.161op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 100.618µs 103.506µs ± 0.725µs 103.591µs ± 0.335µs 103.841µs 104.320µs 105.630µs 107.024µs 3.31% 0.522 4.488 0.70% 0.051µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9343721.111op/s 9661761.412op/s ± 67486.051op/s 9653332.953op/s ± 31189.663op/s 9701011.332op/s 9764894.689op/s 9836615.819op/s 9938619.292op/s 2.96% -0.393 4.268 0.70% 4771.984op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.208µs 1.209µs ± 0.001µs 1.209µs ± 0.000µs 1.209µs 1.212µs 1.212µs 1.214µs 0.46% 1.500 1.133 0.11% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 823652226.260op/s 827106495.960op/s ± 892383.811op/s 827413948.951op/s ± 329987.187op/s 827727956.280op/s 827846652.508op/s 827881792.591op/s 827971944.008op/s 0.07% -1.497 1.121 0.11% 63101.064op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 98.208µs 100.183µs ± 0.609µs 100.224µs ± 0.343µs 100.573µs 101.000µs 101.263µs 102.796µs 2.57% -0.130 2.274 0.61% 0.043µs 1 200
credit_card/is_card_number/378282246310005 throughput 9728052.298op/s 9982057.977op/s ± 60777.634op/s 9977676.455op/s ± 34146.652op/s 10011533.036op/s 10079077.621op/s 10157826.155op/s 10182459.492op/s 2.05% 0.207 2.179 0.61% 4297.628op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 93.644µs 94.946µs ± 0.939µs 94.623µs ± 0.389µs 95.294µs 96.554µs 98.599µs 99.135µs 4.77% 1.941 4.758 0.99% 0.066µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 10087256.692op/s 10533307.120op/s ± 102286.185op/s 10568230.265op/s ± 43608.971op/s 10597340.293op/s 10641618.179op/s 10668668.275op/s 10678764.656op/s 1.05% -1.854 4.341 0.97% 7232.726op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 20.334µs 21.245µs ± 0.372µs 21.242µs ± 0.264µs 21.487µs 21.900µs 22.082µs 22.144µs 4.24% 0.107 -0.427 1.75% 0.026µs 1 200
credit_card/is_card_number/x371413321323331 throughput 45159374.321op/s 47085013.808op/s ± 823905.274op/s 47075908.436op/s ± 577421.152op/s 47727621.738op/s 48463121.282op/s 48805940.945op/s 49179427.704op/s 4.47% -0.025 -0.448 1.75% 58258.901op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.208µs 1.208µs ± 0.000µs 1.208µs ± 0.000µs 1.209µs 1.209µs 1.209µs 1.209µs 0.07% 0.123 -0.759 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 826876483.077op/s 827517082.798op/s ± 236108.051op/s 827476623.236op/s ± 194589.082op/s 827749615.748op/s 827859252.407op/s 827919996.874op/s 827928439.212op/s 0.05% -0.122 -0.761 0.03% 16695.360op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 94.056µs 95.917µs ± 0.580µs 96.013µs ± 0.329µs 96.317µs 96.669µs 97.104µs 97.249µs 1.29% -0.798 0.849 0.60% 0.041µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10282830.234op/s 10426038.640op/s ± 63395.900op/s 10415218.196op/s ± 35592.363op/s 10460090.955op/s 10552170.600op/s 10613003.014op/s 10631996.544op/s 2.08% 0.838 0.923 0.61% 4482.767op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 85.506µs 87.121µs ± 0.540µs 87.130µs ± 0.344µs 87.473µs 87.950µs 88.173µs 88.611µs 1.70% -0.207 0.222 0.62% 0.038µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11285319.370op/s 11478777.315op/s ± 71199.257op/s 11477136.970op/s ± 45273.416op/s 11522971.386op/s 11586522.593op/s 11670288.144op/s 11695021.501op/s 1.90% 0.248 0.260 0.62% 5034.548op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.208µs 1.208µs ± 0.001µs 1.208µs ± 0.000µs 1.209µs 1.209µs 1.209µs 1.216µs 0.60% 7.213 73.123 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 822554369.244op/s 827505347.582op/s ± 452821.741op/s 827521095.872op/s ± 193286.720op/s 827748291.107op/s 827877956.060op/s 827983029.089op/s 827988243.687op/s 0.06% -7.175 72.558 0.05% 32019.332op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 80.184µs 82.899µs ± 0.703µs 82.989µs ± 0.394µs 83.314µs 83.824µs 84.583µs 85.863µs 3.46% -0.105 1.868 0.85% 0.050µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11646433.155op/s 12063682.222op/s ± 102380.332op/s 12049734.538op/s ± 57088.500op/s 12127400.706op/s 12250415.502op/s 12298462.341op/s 12471258.130op/s 3.50% 0.202 1.811 0.85% 7239.383op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 94.286µs 95.770µs ± 0.808µs 95.615µs ± 0.375µs 96.052µs 96.926µs 98.513µs 99.834µs 4.41% 1.960 6.537 0.84% 0.057µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 10016641.935op/s 10442444.485op/s ± 86746.272op/s 10458582.966op/s ± 40826.982op/s 10493805.067op/s 10554103.742op/s 10601475.244op/s 10605972.759op/s 1.41% -1.845 5.945 0.83% 6133.888op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 20.357µs 21.165µs ± 0.351µs 21.157µs ± 0.237µs 21.381µs 21.765µs 22.059µs 22.112µs 4.51% 0.290 -0.016 1.65% 0.025µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 45224551.420op/s 47260476.113op/s ± 780106.274op/s 47264684.423op/s ± 530021.538op/s 47818378.242op/s 48590628.029op/s 48896706.654op/s 49124002.227op/s 3.93% -0.197 -0.082 1.65% 55161.844op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.208µs; 1.209µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ throughput [827421729.832op/s; 827536773.968op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [110.991µs; 111.186µs] or [-0.088%; +0.088%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8994304.308op/s; 9010047.370op/s] or [-0.087%; +0.087%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [103.405µs; 103.606µs] or [-0.097%; +0.097%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9652408.494op/s; 9671114.329op/s] or [-0.097%; +0.097%] None None None
credit_card/is_card_number/37828224631 execution_time [1.209µs; 1.209µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/37828224631 throughput [826982820.146op/s; 827230171.773op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/378282246310005 execution_time [100.099µs; 100.268µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/378282246310005 throughput [9973634.782op/s; 9990481.173op/s] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [94.816µs; 95.076µs] or [-0.137%; +0.137%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [10519131.238op/s; 10547483.001op/s] or [-0.135%; +0.135%] None None None
credit_card/is_card_number/x371413321323331 execution_time [21.193µs; 21.296µs] or [-0.243%; +0.243%] None None None
credit_card/is_card_number/x371413321323331 throughput [46970828.461op/s; 47199199.156op/s] or [-0.243%; +0.243%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.208µs; 1.208µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ throughput [827484360.493op/s; 827549805.103op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [95.837µs; 95.998µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10417252.578op/s; 10434824.702op/s] or [-0.084%; +0.084%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [87.046µs; 87.195µs] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11468909.783op/s; 11488644.848op/s] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.208µs; 1.209µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [827442590.844op/s; 827568104.320op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [82.802µs; 82.997µs] or [-0.117%; +0.117%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12049493.293op/s; 12077871.152op/s] or [-0.118%; +0.118%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [95.658µs; 95.882µs] or [-0.117%; +0.117%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [10430422.286op/s; 10454466.684op/s] or [-0.115%; +0.115%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [21.116µs; 21.214µs] or [-0.230%; +0.230%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [47152360.886op/s; 47368591.340op/s] or [-0.229%; +0.229%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.897µs 26.708µs ± 10.960µs 18.587µs ± 0.528µs 35.014µs 43.316µs 45.845µs 96.883µs 421.23% 2.007 8.712 40.93% 0.775µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [25.189µs; 28.227µs] or [-5.687%; +5.687%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.230µs 1.382µs ± 0.052µs 1.393µs ± 0.037µs 1.420µs 1.454µs 1.478µs 1.479µs 6.18% -0.496 -0.203 3.72% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.375µs; 1.389µs] or [-0.517%; +0.517%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 139.178µs 140.396µs ± 0.376µs 140.432µs ± 0.158µs 140.566µs 140.854µs 141.500µs 142.405µs 1.40% 0.519 6.198 0.27% 0.027µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [140.344µs; 140.448µs] or [-0.037%; +0.037%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a991f56 1726748634 bob/fix-sessions-leak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 293.639ns 307.157ns ± 15.589ns 299.513ns ± 4.708ns 310.979ns 338.007ns 351.147ns 354.437ns 18.34% 1.382 0.872 5.06% 1.102ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [304.997ns; 309.318ns] or [-0.703%; +0.703%] None None None

Baseline

Omitted due to size.

@bwoebi bwoebi merged commit 790a48b into main Sep 19, 2024
30 checks passed
@bwoebi bwoebi deleted the bob/fix-sessions-leak branch September 19, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants