Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustfmt error #645

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix rustfmt error #645

merged 1 commit into from
Sep 23, 2024

Conversation

VianneyRuhlmann
Copy link
Contributor

What does this PR do?

The new nightly version of rustfmt changed some formatting rule

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Sep 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 23, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-09-23 09:09:50

Comparing candidate commit d2e402d in PR branch vianney/fix-rustfmt with baseline commit 13eac56 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 537.586µs 538.092µs ± 0.287µs 538.078µs ± 0.172µs 538.249µs 538.531µs 539.188µs 539.383µs 0.24% 1.151 3.498 0.05% 0.020µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1853971.802op/s 1858418.104op/s ± 989.767op/s 1858467.835op/s ± 593.069op/s 1859057.319op/s 1860011.151op/s 1860146.195op/s 1860166.472op/s 0.09% -1.145 3.472 0.05% 69.987op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 466.644µs 467.239µs ± 0.289µs 467.205µs ± 0.182µs 467.411µs 467.686µs 468.058µs 468.805µs 0.34% 1.131 3.731 0.06% 0.020µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2133083.770op/s 2140234.664op/s ± 1324.156op/s 2140388.535op/s ± 834.429op/s 2141120.943op/s 2142046.499op/s 2142658.464op/s 2142962.438op/s 0.12% -1.122 3.687 0.06% 93.632op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 184.638µs 185.154µs ± 0.208µs 185.136µs ± 0.123µs 185.285µs 185.487µs 185.797µs 185.899µs 0.41% 0.554 0.739 0.11% 0.015µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5379265.808op/s 5400912.352op/s ± 6076.197op/s 5401445.197op/s ± 3579.480op/s 5404705.533op/s 5410255.920op/s 5411831.430op/s 5416007.606op/s 0.27% -0.546 0.722 0.11% 429.652op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.606µs 44.689µs ± 0.038µs 44.687µs ± 0.026µs 44.716µs 44.757µs 44.776µs 44.794µs 0.24% 0.332 -0.229 0.08% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22324191.915op/s 22376865.739op/s ± 18919.363op/s 22378100.384op/s ± 12908.149op/s 22389745.189op/s 22405972.611op/s 22414905.839op/s 22418406.798op/s 0.18% -0.328 -0.232 0.08% 1337.801op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.725µs 49.813µs ± 0.038µs 49.807µs ± 0.012µs 49.830µs 49.878µs 49.913µs 49.969µs 0.33% 0.693 1.677 0.08% 0.003µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20012336.494op/s 20075237.953op/s ± 15247.417op/s 20077606.642op/s ± 5011.991op/s 20082359.990op/s 20100215.880op/s 20109362.129op/s 20110792.591op/s 0.17% -0.686 1.661 0.08% 1078.155op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [538.052µs; 538.132µs] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1858280.932op/s; 1858555.276op/s] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [467.199µs; 467.279µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2140051.149op/s; 2140418.180op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [185.125µs; 185.183µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5400070.249op/s; 5401754.455op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.684µs; 44.694µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22374243.698op/s; 22379487.781op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.807µs; 49.818µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20073124.807op/s; 20077351.098op/s] or [-0.011%; +0.011%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.134µs 1.205µs ± 0.029µs 1.206µs ± 0.017µs 1.229µs 1.241µs 1.243µs 1.245µs 3.20% -0.792 0.026 2.37% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.201µs; 1.209µs] or [-0.329%; +0.329%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 72.498µs 72.761µs ± 0.138µs 72.753µs ± 0.027µs 72.781µs 72.861µs 72.942µs 74.470µs 2.36% 9.468 117.070 0.19% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [72.742µs; 72.780µs] or [-0.026%; +0.026%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 2.415µs 2.416µs ± 0.001µs 2.416µs ± 0.001µs 2.417µs 2.418µs 2.419µs 2.419µs 0.10% 0.759 -0.241 0.04% 0.000µs 1 200
credit_card/is_card_number/ throughput 413441121.699op/s 413837696.976op/s ± 149026.350op/s 413847896.551op/s ± 111559.668op/s 413966048.285op/s 414004093.052op/s 414031866.669op/s 414053862.415op/s 0.05% -0.757 -0.244 0.04% 10537.754op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 111.934µs 115.882µs ± 1.295µs 115.854µs ± 0.916µs 116.869µs 117.752µs 118.658µs 119.023µs 2.74% -0.212 -0.128 1.11% 0.092µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8401716.384op/s 8630548.157op/s ± 96697.662op/s 8631545.136op/s ± 67746.349op/s 8695384.107op/s 8805626.450op/s 8847669.788op/s 8933849.771op/s 3.50% 0.274 -0.072 1.12% 6837.557op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 104.408µs 107.382µs ± 1.533µs 107.405µs ± 1.190µs 108.470µs 109.986µs 110.950µs 110.967µs 3.32% 0.228 -0.598 1.42% 0.108µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9011718.723op/s 9314461.068op/s ± 132595.084op/s 9310531.916op/s ± 102584.336op/s 9420800.332op/s 9523970.843op/s 9570456.974op/s 9577843.667op/s 2.87% -0.171 -0.631 1.42% 9375.888op/s 1 200
credit_card/is_card_number/37828224631 execution_time 2.415µs 2.416µs ± 0.001µs 2.416µs ± 0.001µs 2.417µs 2.418µs 2.420µs 2.428µs 0.51% 5.093 37.009 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 411781261.873op/s 413823471.439op/s ± 243131.977op/s 413862152.306op/s ± 102860.900op/s 413965686.005op/s 414014214.101op/s 414042691.533op/s 414053820.994op/s 0.05% -5.070 36.753 0.06% 17192.027op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 101.524µs 105.693µs ± 1.448µs 105.822µs ± 1.004µs 106.796µs 107.651µs 107.985µs 108.465µs 2.50% -0.621 -0.138 1.37% 0.102µs 1 200
credit_card/is_card_number/378282246310005 throughput 9219535.283op/s 9463149.902op/s ± 130820.717op/s 9449844.978op/s ± 89635.484op/s 9543450.377op/s 9700186.694op/s 9807881.447op/s 9849930.605op/s 4.23% 0.683 -0.026 1.38% 9250.422op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 104.881µs 106.558µs ± 0.449µs 106.618µs ± 0.218µs 106.820µs 107.137µs 107.347µs 108.149µs 1.44% -0.914 2.512 0.42% 0.032µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9246502.510op/s 9384717.242op/s ± 39702.470op/s 9379318.603op/s ± 19109.320op/s 9401475.803op/s 9458244.965op/s 9523737.831op/s 9534624.125op/s 1.66% 0.960 2.581 0.42% 2807.389op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 21.794µs 22.386µs ± 0.343µs 22.354µs ± 0.242µs 22.591µs 23.046µs 23.223µs 23.249µs 4.00% 0.480 -0.468 1.53% 0.024µs 1 200
credit_card/is_card_number/x371413321323331 throughput 43012703.836op/s 44681896.932op/s ± 680594.038op/s 44734702.059op/s ± 488038.234op/s 45230133.423op/s 45656793.029op/s 45873186.690op/s 45883478.540op/s 2.57% -0.421 -0.545 1.52% 48125.266op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 2.415µs 2.416µs ± 0.001µs 2.416µs ± 0.001µs 2.417µs 2.417µs 2.419µs 2.420µs 0.13% 0.682 1.562 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 413273229.820op/s 413846781.293op/s ± 130720.762op/s 413825242.480op/s ± 95950.286op/s 413963429.559op/s 414027713.059op/s 414053783.718op/s 414078012.137op/s 0.06% -0.679 1.550 0.03% 9243.354op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 86.993µs 87.349µs ± 0.309µs 87.281µs ± 0.070µs 87.344µs 87.868µs 88.880µs 89.190µs 2.19% 3.810 16.574 0.35% 0.022µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 11211997.422op/s 11448480.544op/s ± 40002.164op/s 11457184.503op/s ± 9206.404op/s 11467024.280op/s 11477108.849op/s 11486130.444op/s 11495165.134op/s 0.33% -3.767 16.239 0.35% 2828.580op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 79.591µs 80.302µs ± 0.849µs 79.984µs ± 0.224µs 80.419µs 82.411µs 83.235µs 84.996µs 6.27% 2.430 6.590 1.05% 0.060µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11765291.655op/s 12454356.390op/s ± 128428.669op/s 12502557.399op/s ± 35066.408op/s 12530365.147op/s 12551126.764op/s 12553762.367op/s 12564299.057op/s 0.49% -2.349 6.017 1.03% 9081.278op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 2.415µs 2.416µs ± 0.001µs 2.417µs ± 0.000µs 2.417µs 2.417µs 2.418µs 2.419µs 0.11% 0.285 0.319 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 413376376.144op/s 413850829.164op/s ± 115902.013op/s 413816615.954op/s ± 81241.258op/s 413965654.954op/s 414015854.056op/s 414041360.759op/s 414051045.822op/s 0.06% -0.283 0.312 0.03% 8195.510op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 76.664µs 77.060µs ± 0.282µs 76.975µs ± 0.113µs 77.118µs 77.639µs 78.095µs 78.274µs 1.69% 1.899 4.121 0.36% 0.020µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 12775700.853op/s 12977053.973op/s ± 47147.662op/s 12991217.937op/s ± 19064.171op/s 13006310.337op/s 13023174.762op/s 13036495.430op/s 13043935.889op/s 0.41% -1.872 3.994 0.36% 3333.843op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 105.120µs 106.548µs ± 0.456µs 106.594µs ± 0.243µs 106.810µs 107.151µs 107.655µs 107.919µs 1.24% -0.558 1.256 0.43% 0.032µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9266205.262op/s 9385614.876op/s ± 40237.049op/s 9381347.536op/s ± 21379.924op/s 9405243.669op/s 9463852.471op/s 9502386.649op/s 9512980.918op/s 1.40% 0.596 1.290 0.43% 2845.189op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 21.709µs 22.722µs ± 0.342µs 22.743µs ± 0.211µs 22.947µs 23.221µs 23.533µs 23.574µs 3.65% -0.276 0.190 1.50% 0.024µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 42419890.716op/s 44019255.028op/s ± 665586.300op/s 43969697.546op/s ± 405715.170op/s 44382831.098op/s 45206303.076op/s 45718263.520op/s 46064033.856op/s 4.76% 0.371 0.251 1.51% 47064.059op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [2.416µs; 2.417µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/ throughput [413817043.358op/s; 413858350.595op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [115.702µs; 116.061µs] or [-0.155%; +0.155%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8617146.791op/s; 8643949.523op/s] or [-0.155%; +0.155%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [107.169µs; 107.594µs] or [-0.198%; +0.198%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9296084.664op/s; 9332837.471op/s] or [-0.197%; +0.197%] None None None
credit_card/is_card_number/37828224631 execution_time [2.416µs; 2.417µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [413789775.685op/s; 413857167.193op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [105.492µs; 105.894µs] or [-0.190%; +0.190%] None None None
credit_card/is_card_number/378282246310005 throughput [9445019.409op/s; 9481280.395op/s] or [-0.192%; +0.192%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [106.496µs; 106.620µs] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9379214.861op/s; 9390219.622op/s] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/x371413321323331 execution_time [22.338µs; 22.433µs] or [-0.213%; +0.213%] None None None
credit_card/is_card_number/x371413321323331 throughput [44587573.144op/s; 44776220.720op/s] or [-0.211%; +0.211%] None None None
credit_card/is_card_number_no_luhn/ execution_time [2.416µs; 2.416µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ throughput [413828664.653op/s; 413864897.934op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [87.306µs; 87.392µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [11442936.628op/s; 11454024.459op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [80.184µs; 80.420µs] or [-0.147%; +0.147%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [12436557.412op/s; 12472155.369op/s] or [-0.143%; +0.143%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [2.416µs; 2.416µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [413834766.260op/s; 413866892.069op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [77.021µs; 77.099µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12970519.761op/s; 12983588.186op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [106.485µs; 106.611µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9380038.408op/s; 9391191.344op/s] or [-0.059%; +0.059%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [22.675µs; 22.770µs] or [-0.209%; +0.209%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [43927011.168op/s; 44111498.888op/s] or [-0.210%; +0.210%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 276.007µs 276.264µs ± 0.146µs 276.266µs ± 0.094µs 276.368µs 276.501µs 276.571µs 276.834µs 0.21% 0.321 0.293 0.05% 0.010µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3612271.259op/s 3619727.392op/s ± 1907.719op/s 3619694.207op/s ± 1232.308op/s 3620853.105op/s 3622697.866op/s 3622937.244op/s 3623099.684op/s 0.09% -0.318 0.285 0.05% 134.896op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 28.046µs 28.096µs ± 0.040µs 28.079µs ± 0.020µs 28.114µs 28.173µs 28.200µs 28.210µs 0.47% 0.928 -0.120 0.14% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35448845.441op/s 35592128.090op/s ± 50284.965op/s 35613723.668op/s ± 25147.649op/s 35633333.682op/s 35638359.609op/s 35639741.561op/s 35655158.393op/s 0.12% -0.923 -0.132 0.14% 3555.684op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.348µs 16.462µs ± 0.041µs 16.461µs ± 0.026µs 16.491µs 16.523µs 16.531µs 16.669µs 1.26% 0.325 2.686 0.25% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 59992241.681op/s 60746688.111op/s ± 149406.556op/s 60749697.603op/s ± 94181.099op/s 60835098.352op/s 60996121.008op/s 61123758.482op/s 61170513.324op/s 0.69% -0.292 2.565 0.25% 10564.639op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [276.244µs; 276.284µs] or [-0.007%; +0.007%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3619463.000op/s; 3619991.783op/s] or [-0.007%; +0.007%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [28.091µs; 28.102µs] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [35585159.077op/s; 35599097.102op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.456µs; 16.468µs] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/good throughput [60725981.799op/s; 60767394.422op/s] or [-0.034%; +0.034%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 296.658ns 307.392ns ± 12.662ns 302.090ns ± 3.839ns 312.834ns 332.206ns 352.624ns 355.053ns 17.53% 2.084 4.313 4.11% 0.895ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [305.637ns; 309.147ns] or [-0.571%; +0.571%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.397µs 3.185µs ± 1.540µs 3.034µs ± 0.023µs 3.052µs 3.111µs 13.807µs 17.650µs 481.78% 7.956 63.945 48.25% 0.109µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.971µs; 3.398µs] or [-6.703%; +6.703%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 143.249µs 144.091µs ± 0.489µs 143.987µs ± 0.155µs 144.176µs 144.852µs 146.658µs 147.286µs 2.29% 3.318 15.734 0.34% 0.035µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [144.024µs; 144.159µs] or [-0.047%; +0.047%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.047µs 38.707µs ± 1.156µs 38.184µs ± 0.046µs 38.268µs 41.196µs 41.238µs 42.340µs 10.88% 1.725 1.059 2.98% 0.082µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.547µs; 38.867µs] or [-0.414%; +0.414%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.740µs 25.981µs ± 11.246µs 18.070µs ± 0.258µs 35.222µs 36.254µs 53.393µs 97.041µs 437.02% 2.572 12.984 43.18% 0.795µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.422µs; 27.539µs] or [-5.999%; +5.999%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.984ms 9.020ms ± 0.017ms 9.020ms ± 0.009ms 9.029ms 9.043ms 9.051ms 9.172ms 1.69% 3.276 27.487 0.19% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.018ms; 9.023ms] or [-0.027%; +0.027%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d2e402d 1727081940 vianney/fix-rustfmt
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.727µs 2.758µs ± 0.012µs 2.758µs ± 0.007µs 2.764µs 2.782µs 2.789µs 2.795µs 1.33% 0.420 0.879 0.43% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.756µs; 2.760µs] or [-0.060%; +0.060%] None None None

Baseline

Omitted due to size.

@VianneyRuhlmann VianneyRuhlmann marked this pull request as ready for review September 23, 2024 09:19
@VianneyRuhlmann VianneyRuhlmann requested a review from a team as a code owner September 23, 2024 09:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (13eac56) to head (d2e402d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   73.58%   73.60%   +0.02%     
==========================================
  Files         255      255              
  Lines       36941    36941              
==========================================
+ Hits        27182    27190       +8     
+ Misses       9759     9751       -8     
Components Coverage Δ
crashtracker 20.53% <ø> (ø)
datadog-alloc 98.73% <ø> (+0.14%) ⬆️
data-pipeline 91.65% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ipc 83.58% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.10% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.47% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.41% <ø> (ø)

Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not for this PR, but I think that we should lock down the nightly version, e.g. use nightly-2024-09-22, to avoid this kind of unexpected breakage.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks for fixing this up

@VianneyRuhlmann VianneyRuhlmann merged commit b3098a1 into main Sep 23, 2024
30 checks passed
@VianneyRuhlmann VianneyRuhlmann deleted the vianney/fix-rustfmt branch September 23, 2024 09:46
duncanpharvey pushed a commit that referenced this pull request Oct 12, 2024
duncanpharvey pushed a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the profiling* modules.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants