Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prefer DD_PROXY_HTTPS over HTTPS_PROXY #673

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Oct 11, 2024

What does this PR do?

In my earlier PR I made two mistakes:

  1. With bleary newborn-parent eyes I didn't realize it was DD_PROXY_HTTPS, I had inverted it.
  2. I had hoped that I could simply use the linux native HTTPS_PROXY env var, but our customer is correct and we'll need support for both.

These env vars are enforced in priority order as per the docs:

  1. DD_PROXY_HTTPS
  2. HTTPS_PROXY
  3. yaml config file (not used here)

This PR adds support for this for both dogstatsd and the trace mini agent.

I've verified both configs are still valid and work.
Traces:
traces

Metrics:
metrics

(and logs, but that's not part of libdatadog)

Motivation

finishing what I started

@astuyve astuyve requested review from a team as code owners October 11, 2024 18:05
@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-10-16 17:56:53

Comparing candidate commit 0bed4de in PR branch aj/prefer-ddproxy-over-https-proxy with baseline commit 9b01c90 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

  • 🟩 execution_time [-10.164µs; -9.920µs] or [-10.278%; -10.031%]
  • 🟩 throughput [+1129356.683op/s; +1155950.860op/s] or [+11.167%; +11.430%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.873ms 8.909ms ± 0.022ms 8.908ms ± 0.009ms 8.917ms 8.931ms 8.949ms 9.161ms 2.84% 7.127 78.142 0.25% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.906ms; 8.912ms] or [-0.035%; +0.035%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.125µs 1.182µs ± 0.023µs 1.183µs ± 0.017µs 1.203µs 1.206µs 1.208µs 1.208µs 2.12% -0.887 -0.083 1.97% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.179µs; 1.185µs] or [-0.273%; +0.273%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.701µs 2.726µs ± 0.013µs 2.723µs ± 0.005µs 2.729µs 2.762µs 2.765µs 2.776µs 1.95% 1.916 4.072 0.47% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.724µs; 2.728µs] or [-0.066%; +0.066%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 2.013µs 2.014µs ± 0.002µs 2.014µs ± 0.000µs 2.014µs 2.015µs 2.016µs 2.043µs 1.42% 11.969 156.564 0.11% 0.000µs 1 200
credit_card/is_card_number/ throughput 489526199.559op/s 496501844.530op/s ± 524078.336op/s 496497175.436op/s ± 101293.422op/s 496688311.182op/s 496762476.103op/s 496797499.372op/s 496848573.341op/s 0.07% -11.920 155.672 0.11% 37057.935op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 117.952µs 118.822µs ± 0.375µs 118.769µs ± 0.234µs 119.060µs 119.450µs 119.703µs 120.462µs 1.43% 0.637 1.155 0.31% 0.027µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8301351.968op/s 8416028.833op/s ± 26515.997op/s 8419686.722op/s ± 16583.070op/s 8432769.117op/s 8453330.053op/s 8469417.523op/s 8478043.563op/s 0.69% -0.611 1.083 0.31% 1874.964op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 109.403µs 110.227µs ± 0.317µs 110.197µs ± 0.172µs 110.397µs 110.850µs 111.149µs 111.331µs 1.03% 0.664 0.887 0.29% 0.022µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8982199.354op/s 9072251.757op/s ± 26041.180op/s 9074667.165op/s ± 14184.450op/s 9088523.240op/s 9110709.291op/s 9119364.210op/s 9140510.744op/s 0.73% -0.643 0.849 0.29% 1841.390op/s 1 200
credit_card/is_card_number/37828224631 execution_time 2.013µs 2.014µs ± 0.002µs 2.014µs ± 0.001µs 2.014µs 2.015µs 2.018µs 2.035µs 1.04% 9.709 115.235 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 491406326.535op/s 496497371.333op/s ± 413133.939op/s 496513110.206op/s ± 135623.359op/s 496685939.086op/s 496737365.268op/s 496764902.601op/s 496784605.159op/s 0.05% -9.651 114.237 0.08% 29212.981op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 105.410µs 106.151µs ± 0.323µs 106.151µs ± 0.196µs 106.330µs 106.747µs 106.954µs 107.008µs 0.81% 0.271 -0.010 0.30% 0.023µs 1 200
credit_card/is_card_number/378282246310005 throughput 9345113.160op/s 9420672.969op/s ± 28633.959op/s 9420522.354op/s ± 17386.420op/s 9440147.577op/s 9465793.659op/s 9479531.219op/s 9486739.436op/s 0.70% -0.254 -0.026 0.30% 2024.727op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 103.795µs 104.976µs ± 0.584µs 104.962µs ± 0.441µs 105.378µs 105.924µs 106.353µs 106.682µs 1.64% 0.276 -0.348 0.55% 0.041µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9373634.232op/s 9526279.779op/s ± 52916.160op/s 9527276.871op/s ± 39980.937op/s 9568027.484op/s 9608692.858op/s 9626437.414op/s 9634416.061op/s 1.12% -0.250 -0.380 0.55% 3741.738op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 23.244µs 24.044µs ± 0.386µs 24.056µs ± 0.311µs 24.373µs 24.581µs 24.888µs 25.121µs 4.43% -0.088 -0.574 1.60% 0.027µs 1 200
credit_card/is_card_number/x371413321323331 throughput 39807557.796op/s 41601923.865op/s ± 669416.629op/s 41570235.988op/s ± 533050.713op/s 42042961.023op/s 42722972.429op/s 43017641.842op/s 43022537.486op/s 3.49% 0.155 -0.586 1.61% 47334.904op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.001µs 2.014µs 2.015µs 2.016µs 2.023µs 0.44% 3.836 29.385 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 494373070.411op/s 496515656.322op/s ± 242075.721op/s 496536199.880op/s ± 137790.327op/s 496690563.980op/s 496735303.781op/s 496789903.072op/s 496799277.579op/s 0.05% -3.811 29.091 0.05% 17117.338op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 97.195µs 97.799µs ± 0.372µs 97.734µs ± 0.240µs 97.994µs 98.498µs 98.833µs 99.240µs 1.54% 0.909 0.711 0.38% 0.026µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10076535.691op/s 10225196.612op/s ± 38774.276op/s 10231813.668op/s ± 25120.856op/s 10254721.560op/s 10275230.017op/s 10282623.605op/s 10288580.704op/s 0.55% -0.888 0.646 0.38% 2741.755op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 88.021µs 88.845µs ± 0.433µs 88.797µs ± 0.299µs 89.109µs 89.567µs 90.242µs 90.423µs 1.83% 0.701 0.709 0.49% 0.031µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11059192.714op/s 11255806.870op/s ± 54665.717op/s 11261687.738op/s ± 38093.616op/s 11297523.868op/s 11333349.127op/s 11354182.751op/s 11360919.523op/s 0.88% -0.669 0.624 0.48% 3865.450op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 2.012µs 2.014µs ± 0.001µs 2.014µs ± 0.000µs 2.014µs 2.015µs 2.015µs 2.017µs 0.12% 0.247 0.643 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 495890005.704op/s 496537974.800op/s ± 147788.721op/s 496502159.785op/s ± 98437.287op/s 496683735.731op/s 496745794.787op/s 496791146.972op/s 496901943.982op/s 0.08% -0.245 0.635 0.03% 10450.241op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 83.719µs 84.708µs ± 0.477µs 84.670µs ± 0.357µs 85.071µs 85.563µs 85.754µs 86.167µs 1.77% 0.331 -0.397 0.56% 0.034µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11605384.662op/s 11805575.856op/s ± 66414.686op/s 11810490.682op/s ± 49624.953op/s 11858029.049op/s 11909774.249op/s 11921255.923op/s 11944695.654op/s 1.14% -0.306 -0.424 0.56% 4696.227op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 103.820µs 105.035µs ± 0.610µs 104.983µs ± 0.444µs 105.490µs 106.084µs 106.301µs 106.543µs 1.49% 0.175 -0.712 0.58% 0.043µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9385880.839op/s 9520942.122op/s ± 55227.296op/s 9525393.804op/s ± 40295.509op/s 9562723.786op/s 9610227.878op/s 9619712.265op/s 9632011.992op/s 1.12% -0.153 -0.722 0.58% 3905.160op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 23.166µs 24.106µs ± 0.450µs 24.093µs ± 0.292µs 24.375µs 24.962µs 25.281µs 25.798µs 7.08% 0.515 0.726 1.86% 0.032µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 38762242.565op/s 41497511.155op/s ± 768746.752op/s 41505475.186op/s ± 499849.122op/s 42022943.177op/s 42794549.746op/s 43006953.825op/s 43166085.706op/s 4.00% -0.382 0.484 1.85% 54358.604op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [2.014µs; 2.014µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/ throughput [496429212.313op/s; 496574476.747op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [118.770µs; 118.874µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8412353.971op/s; 8419703.695op/s] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [110.183µs; 110.271µs] or [-0.040%; +0.040%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9068642.700op/s; 9075860.814op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number/37828224631 execution_time [2.014µs; 2.014µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [496440114.942op/s; 496554627.724op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [106.106µs; 106.195µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number/378282246310005 throughput [9416704.578op/s; 9424641.361op/s] or [-0.042%; +0.042%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [104.895µs; 105.057µs] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9518946.108op/s; 9533613.450op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/x371413321323331 execution_time [23.990µs; 24.097µs] or [-0.223%; +0.223%] None None None
credit_card/is_card_number/x371413321323331 throughput [41509149.158op/s; 41694698.571op/s] or [-0.223%; +0.223%] None None None
credit_card/is_card_number_no_luhn/ execution_time [2.014µs; 2.014µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ throughput [496482106.955op/s; 496549205.688op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [97.747µs; 97.851µs] or [-0.053%; +0.053%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10219822.871op/s; 10230570.354op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [88.785µs; 88.905µs] or [-0.068%; +0.068%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11248230.727op/s; 11263383.012op/s] or [-0.067%; +0.067%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [2.014µs; 2.014µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [496517492.705op/s; 496558456.895op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [84.642µs; 84.775µs] or [-0.078%; +0.078%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [11796371.420op/s; 11814780.293op/s] or [-0.078%; +0.078%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [104.951µs; 105.120µs] or [-0.080%; +0.080%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9513288.150op/s; 9528596.094op/s] or [-0.080%; +0.080%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [24.044µs; 24.169µs] or [-0.259%; +0.259%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [41390970.249op/s; 41604052.062op/s] or [-0.257%; +0.257%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 80.495µs 80.688µs ± 0.183µs 80.668µs ± 0.027µs 80.695µs 80.744µs 81.471µs 82.801µs 2.64% 9.011 93.235 0.23% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [80.663µs; 80.713µs] or [-0.031%; +0.031%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.400µs 3.184µs ± 1.371µs 3.037µs ± 0.021µs 3.055µs 3.121µs 13.718µs 14.706µs 384.23% 7.567 57.562 42.95% 0.097µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.994µs; 3.374µs] or [-5.968%; +5.968%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 186.872µs 191.072µs ± 1.607µs 190.983µs ± 1.036µs 192.310µs 193.606µs 194.326µs 195.097µs 2.15% -0.141 -0.089 0.84% 0.114µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5125648.529op/s 5234008.725op/s ± 44080.079op/s 5236064.885op/s ± 28546.635op/s 5261664.121op/s 5318311.148op/s 5343175.069op/s 5351242.911op/s 2.20% 0.189 -0.057 0.84% 3116.932op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.172µs 18.205µs ± 0.026µs 18.190µs ± 0.013µs 18.225µs 18.247µs 18.280µs 18.292µs 0.56% 0.836 0.061 0.14% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54667339.971op/s 54930768.355op/s ± 79029.560op/s 54975197.104op/s ± 38394.285op/s 54996546.986op/s 55014029.989op/s 55023783.332op/s 55028894.833op/s 0.10% -0.830 0.041 0.14% 5588.234op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.283µs 11.325µs ± 0.032µs 11.316µs ± 0.014µs 11.341µs 11.375µs 11.407µs 11.556µs 2.12% 2.568 13.352 0.28% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 86536888.377op/s 88299104.593op/s ± 243945.584op/s 88370052.379op/s ± 108455.996op/s 88459201.390op/s 88546212.074op/s 88609990.187op/s 88629340.328op/s 0.29% -2.496 12.652 0.28% 17249.558op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [190.849µs; 191.294µs] or [-0.117%; +0.117%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5227899.650op/s; 5240117.800op/s] or [-0.117%; +0.117%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.201µs; 18.208µs] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54919815.618op/s; 54941721.092op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/good execution_time [11.321µs; 11.330µs] or [-0.039%; +0.039%] None None None
normalization/normalize_name/normalize_name/good throughput [88265296.082op/s; 88332913.105op/s] or [-0.038%; +0.038%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.273µs 37.820µs ± 1.008µs 37.344µs ± 0.037µs 37.471µs 39.988µs 40.028µs 40.583µs 8.67% 1.698 0.934 2.66% 0.071µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.680µs; 37.959µs] or [-0.369%; +0.369%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 257.206ns 271.643ns ± 17.150ns 263.354ns ± 5.073ns 278.372ns 307.315ns 315.614ns 316.423ns 20.15% 1.224 0.178 6.30% 1.213ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [269.266ns; 274.020ns] or [-0.875%; +0.875%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 623.568µs 624.668µs ± 0.387µs 624.656µs ± 0.249µs 624.942µs 625.321µs 625.654µs 625.886µs 0.20% 0.126 0.446 0.06% 0.027µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1597735.598op/s 1600851.783op/s ± 992.142op/s 1600881.674op/s ± 637.573op/s 1601500.789op/s 1602389.309op/s 1603167.052op/s 1603675.073op/s 0.17% -0.122 0.445 0.06% 70.155op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 462.952µs 464.843µs ± 0.499µs 464.874µs ± 0.331µs 465.165µs 465.600µs 465.900µs 465.956µs 0.23% -0.509 0.924 0.11% 0.035µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2146126.840op/s 2151265.360op/s ± 2308.615op/s 2151120.397op/s ± 1532.134op/s 2152756.667op/s 2155072.092op/s 2158316.667op/s 2160052.132op/s 0.42% 0.517 0.943 0.11% 163.244op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 178.158µs 178.358µs ± 0.101µs 178.358µs ± 0.047µs 178.401µs 178.523µs 178.609µs 178.997µs 0.36% 1.476 7.157 0.06% 0.007µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5586682.004op/s 5606687.898op/s ± 3176.773op/s 5606701.129op/s ± 1475.528op/s 5608449.012op/s 5611046.064op/s 5612707.013op/s 5612995.975op/s 0.11% -1.464 7.076 0.06% 224.632op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.726µs 46.896µs ± 0.074µs 46.892µs ± 0.048µs 46.939µs 47.026µs 47.068µs 47.112µs 0.47% 0.332 -0.061 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21225874.009op/s 21323875.867op/s ± 33832.647op/s 21325765.360op/s ± 21648.180op/s 21346804.732op/s 21377473.419op/s 21392309.260op/s 21401136.992op/s 0.35% -0.323 -0.069 0.16% 2392.329op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.063µs 49.516µs ± 0.179µs 49.510µs ± 0.107µs 49.611µs 49.773µs 49.878µs 50.795µs 2.60% 1.842 11.906 0.36% 0.013µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19686801.305op/s 20195858.294op/s ± 72638.960op/s 20197963.543op/s ± 43422.743op/s 20242200.282op/s 20294134.221op/s 20342006.611op/s 20381962.721op/s 0.91% -1.731 11.003 0.36% 5136.350op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [624.614µs; 624.721µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1600714.281op/s; 1600989.284op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [464.774µs; 464.912µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2150945.408op/s; 2151585.312op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [178.344µs; 178.372µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5606247.628op/s; 5607128.168op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.886µs; 46.906µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21319186.987op/s; 21328564.746op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.491µs; 49.541µs] or [-0.050%; +0.050%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20185791.233op/s; 20205925.355op/s] or [-0.050%; +0.050%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.983µs 142.878µs ± 0.477µs 142.812µs ± 0.174µs 142.992µs 143.518µs 144.216µs 146.337µs 2.47% 3.821 24.242 0.33% 0.034µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.812µs; 142.944µs] or [-0.046%; +0.046%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0bed4de 1729100791 aj/prefer-ddproxy-over-https-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.970µs 25.585µs ± 11.977µs 19.870µs ± 0.316µs 24.746µs 45.849µs 50.722µs 105.535µs 431.12% 3.062 13.978 46.70% 0.847µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.925µs; 27.245µs] or [-6.488%; +6.488%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (9b01c90) to head (0bed4de).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   71.79%   71.80%           
=======================================
  Files         271      271           
  Lines       40935    40960   +25     
=======================================
+ Hits        29391    29413   +22     
- Misses      11544    11547    +3     
Components Coverage Δ
crashtracker 20.36% <ø> (ø)
crashtracker-ffi 9.07% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.92% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.73% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 88.86% <80.95%> (-0.19%) ⬇️
dogstatsd-client 79.77% <ø> (ø)
ipc 82.65% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <0.00%> (ø)
sidecar 36.08% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <100.00%> (+0.04%) ⬆️
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.48% <ø> (ø)

@astuyve astuyve merged commit 92272e9 into main Oct 16, 2024
30 checks passed
@astuyve astuyve deleted the aj/prefer-ddproxy-over-https-proxy branch October 16, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants