Add .pprof to api::Profile helper #75
Conversation
morrisonlevi
changed the title
| pub struct Profile<'a> { | ||
| pub duration: Duration, | ||
| pub period: Option<(i64, ValueType<'a>)>, | ||
| pub sample_types: Vec<ValueType<'a>>, | ||
| pub samples: Vec<Sample<'a>>, | ||
| pub start_time: SystemTime, | ||
| } |
There was a problem hiding this comment.
Given the assumption
There are no changes to shipped code, so there shouldn't be anything to test.
Should this be inside the mod test? And perhaps also document the assumption in the code, so that other/newer team members know that this isn't expected to be used outside of libdatadog testing.
There was a problem hiding this comment.
Maybe. I need to see what configuration the bench configuration uses -- I know it uses public APIs only, but I'm not sure if it builds with test or not, so that's the only reason I didn't immediately slap it into #[cfg(test)].
profiling/tests/wordpress.pprof
Outdated
| @@ -0,0 +1,4441 @@ | |||
|
|
|||
There was a problem hiding this comment.
Consider perhaps compressing this file as pprof.gz or something OR at least telling github not to render them https://thoughtbot.com/blog/github-diff-supression :)
What does this PR do?
api::Profile.TryFrom<&pprof::Profile> for api::Profile.Motivation
This is a precursor PR for benchmarking hashing functions or other changes. This allows us to read in a pprof from disk and get an
api::Profilefrom it, which we can use to add to the regular profile API. This allows us to benchmark adding samples, interning strings, etc.Additional Notes
I wrote the tests for those samples by hand -- they aren't auto-generated. It's a very slow process.
How to test the change?
There are no changes to shipped code, so there shouldn't be anything to test.