Remove unused optional time dependency
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR tweaks the optional features of the `chrono` crate to avoid pulling in the `time` crate. **Motivation**: We got warned by dependabot that the version of `time` pulled in by `chrono` is a deprecated version that should no longer be used. Since we were not actually making use of any of the features provided by it, we can just remove it. **Additional Notes**: (N/A) **How to test the change?**: Validate that all tests still pass.
|
See https://github.com/DataDog/libdatadog/security/dependabot/4 for details on the dependabot complaint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR tweaks the optional features of the
chronocrate to avoid pulling in thetimecrate.Motivation:
We got warned by dependabot that the version of
timepulled in bychronois a deprecated version that should no longer be used.Since we were not actually making use of any of the features provided by it, we can just remove it.
Additional Notes:
(N/A)
How to test the change?:
Validate that all tests still pass.