Tag cannot end with colon

DataDog · Mar 30, 2022 · 43b484f · 43b484f
1 parent ab1ceb5
commit 43b484f
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/ddprof-ffi/src/exporter.rs b/ddprof-ffi/src/exporter.rs
@@ -311,7 +311,9 @@ fn parse_tag_chunk(chunk: &str) -> Result<Tag, TagsError> {
             return Err(TagsError {
                 message: format!("tag cannot start with a colon: \"{}\"", chunk),
             });
-        } else if first_colon_position == chunk.chars().count() {
+        }
+
+        if chunk.ends_with(':') {
             return Err(TagsError {
                 message: format!("tag cannot end with a colon: \"{}\"", chunk),
             });
@@ -494,6 +496,10 @@ mod test {
                     Tag::new("key3", "value3"),
                 ],
             ),
+            (
+                "key1:",
+                vec![],
+            ),
         ];
 
         for case in cases {