Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Add Vec type, remove Buffer, add SendResult_drop #41

Merged
merged 8 commits into from
Mar 31, 2022
Merged

Commits on Mar 30, 2022

  1. Configuration menu
    Copy the full SHA
    04a8a9d View commit details
    Browse the repository at this point in the history
  2. Update examples

    morrisonlevi committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    7a9d08b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08b4fe5 View commit details
    Browse the repository at this point in the history
  4. Add Vec type, remove Buffer, add SendResult_drop

    The Vec type is a generalization of Buffer. In particular, this PR
    exposes an API to create and manage Vec<Tag> and replaces existing uses
    of Buffer with Vec<u8>. It includes a helper to parse DD_TAGS as well.
    
    One of the APIs, ddprof_ffi_Buffer_reset, was removed. Previously this
    was required when using the failure case of the SendResult type, but
    now there is ddprof_ffi_SendResult_drop, which should be used instead.
    morrisonlevi committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    6b9bfbf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4fb22b3 View commit details
    Browse the repository at this point in the history
  6. Improve tag parsing and Slices

    Previously it couldn't handle a tags like:
      env:staging:east
      value
    
    Tag messages on failure have improved.
    
    As part of adding tests, added more trait support to Slice and
    CharSlice so they can be used in equivalence statements.
    
    As part of doing that, I realized Slice could implement IntoIterator
    and that it cleaned up 3+ places where we call .into_slice().iter().
    I also removed unsafe from `into_slice`. Technically, it could still
    fail such as if the user creates a slice of length 4 but only has 2
    elements, but this is a user error that cannot really be checked.
    morrisonlevi committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    ab1ceb5 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Configuration menu
    Copy the full SHA
    d2a9ca9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb6b972 View commit details
    Browse the repository at this point in the history