This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Github CI lint and and tests #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
force-pushed
the
pull_github_actions
branch
from
3735be2
to
7284ad2
Compare
ivoanjo
approved these changes
Apr 5, 2022
Comment on lines
+7
to
+16
| test: | ||
| name: cargo test --workspace | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout sources | ||
| uses: actions/checkout@v2 | ||
| - name: Cache | ||
| uses: ./.github/actions/cache | ||
| - run: cargo build --workspace --verbose | ||
| - run: cargo test --workspace --verbose |
There was a problem hiding this comment.
Can I convince you to also build the examples/ffi? We've had issues with them bitrotting in the past so it'd be great to have them running in CI :)
There was a problem hiding this comment.
Yeah, we should definitely add that build to the CI. But it seems I need to basically build the end artifact to make cmake happy.
I have another proposal in progress, which builds the world using bazel its not handling the example yet.
But once it does - it would just be this invocation in the CI for build checking everything:
bazel build //...Bazel or no bazel, we'll definitely need to check this in CI at some point. So I can take a note, to return to it, if we decide bazel sucks too much :)
r1viollet
approved these changes
Apr 5, 2022
morrisonlevi
approved these changes
Apr 12, 2022
|
Thanks all for the review ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds basic CI Lints and Tests in Github actions.
Motivation
Quick feedback and lint check for submitted PRs