pkg/otlp/metrics: add remapping code #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/remap-metrics
branch
5 times, most recently
from
4994488
to
7a2cad7
Compare
mx-psi
reviewed
Jun 14, 2023
|
I guess this is ready for review and fully tested now, but there seems to have been a breaking change in a dependency which is causing the CI to fail oddly. |
I think it will be fixed once you rebase/merge main |
This change adds the processing code for extracting Datadog metrics from container.* and system.* metrics with the intention of centralising this logic to be re-used in the backend intake. The operation is restricted by the newly added WithRemapping translator configuration option, so that it does not affect the translator's usage as part of the Datadog Agent, where no remapping is necessary because the agent creates the necessary metrics.
songy23
reviewed
Jun 15, 2023
mx-psi
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the processing code for extracting Datadog metrics from container.* and system.* metrics with the intention of centralising this logic to be re-used in the backend intake.
The operation is restricted by the newly added WithRemapping translator configuration option, so that it does not affect the translator's usage as part of the Datadog Agent, where no remapping is necessary because the agent creates the necessary metrics.
Closes #102