Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/otlp/metrics] Add WithSplatArrayAttributes #331

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented May 17, 2024

What does this PR do?

Adds support for 'splatting' array attributes into multiple tags with the same key and different values

Motivation

Updates #329

@mx-psi mx-psi added the breaking-change This PR introduces a Go API breaking change label May 17, 2024
@mx-psi mx-psi marked this pull request as ready for review May 17, 2024 19:15
@mx-psi mx-psi requested a review from a team as a code owner May 17, 2024 19:15
@mx-psi mx-psi requested a review from mackjmr May 17, 2024 19:15
@mx-psi mx-psi requested a review from mackjmr May 20, 2024 10:45
@mx-psi
Copy link
Member Author

mx-psi commented May 20, 2024

Re-requesting review since the code changed a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This PR introduces a Go API breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants