fix: cannot lazily link against GLS accessors #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 52.53% 52.47% -0.07%
==========================================
Files 86 87 +1
Lines 4492 4503 +11
==========================================
+ Hits 2360 2363 +3
- Misses 1886 1892 +6
- Partials 246 248 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9 tasks
In order to be able to lazily link against GLS accessors, these need to be declared as variables instead of functions. This allows creation of bindings on the other side that can be conditionally satisffied by the existence of initialized declarations somewhere else. Adds an integration test to demonstrate it is possible to build programs with and without the runtime modification using this technique.
RomainMuller
force-pushed
the
romain.marcadier/gls-enablement
branch
from
b6fc3f9
to
9fd7dde
Compare
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: github-actions on behalf of eliottness <github-actions@github.com>
eliottness
reviewed
Jul 8, 2024
felixge
reviewed
Jul 10, 2024
felixge
approved these changes
Jul 10, 2024
…enablement # Conflicts: # .github/workflows/tests.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to lazily link against GLS accessors, these need to be declared as variables instead of functions. This allows creation of bindings on the other side that can be conditionally satisffied by the existence of initialized declarations somewhere else.
Adds an integration test to demonstrate it is possible to build programs with and without the runtime modification using this technique.
Enables: DataDog/dd-trace-go#2761
JIRA: APPSEC-53654