Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use oldstable and stable for running workflows #227

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

RomainMuller
Copy link
Contributor

This allows us to never have to change our workflow configuration when a new go release is issued, as these labels automatically resolve via the published release manifest.

Also uses go.mod files instead of go.sum files to compute cache keys, as the go.sum files are technically not a dependency manifest.

This allows us to never have to change our workflow configuration when a new
go release is issued, as these labels automatically resolve via the published
release manifest.
@RomainMuller RomainMuller requested a review from a team as a code owner August 19, 2024 14:46
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.50%. Comparing base (9bd25ae) to head (e541fbb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   61.50%   61.50%           
=======================================
  Files          90       90           
  Lines        4915     4915           
=======================================
  Hits         3023     3023           
  Misses       1569     1569           
  Partials      323      323           
Flag Coverage Δ
ARM64 44.68% <ø> (ø)
Linux 66.13% <ø> (ø)
Windows 43.56% <ø> (ø)
X64 61.50% <ø> (ø)
generator 42.71% <ø> (ø)
go 50.96% <ø> (?)
go1.22 44.68% <ø> (-6.28%) ⬇️
go1.23 44.46% <ø> (-5.29%) ⬇️
integration 46.19% <ø> (ø)
macOS 44.68% <ø> (ø)
unit 41.21% <ø> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainMuller RomainMuller added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 2244821 Aug 20, 2024
20 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/no-gotip branch August 20, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants