Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: uniformly pass log.Tracef as packages.Load logger #229

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

RomainMuller
Copy link
Contributor

This allows to get more debugging information with the TRACE log level.

@RomainMuller RomainMuller requested a review from a team as a code owner August 19, 2024 15:05
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.49%. Comparing base (9bd25ae) to head (6ce4484).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   61.50%   61.49%   -0.01%     
==========================================
  Files          90       90              
  Lines        4915     4914       -1     
==========================================
- Hits         3023     3022       -1     
  Misses       1569     1569              
  Partials      323      323              
Flag Coverage Δ
ARM64 44.68% <100.00%> (ø)
Linux 66.13% <100.00%> (ø)
Windows 43.54% <100.00%> (-0.02%) ⬇️
X64 61.49% <100.00%> (-0.01%) ⬇️
generator 42.71% <ø> (ø)
go1.22 50.95% <100.00%> (-0.01%) ⬇️
go1.23 49.73% <100.00%> (-0.02%) ⬇️
integration 46.18% <100.00%> (-0.02%) ⬇️
macOS 44.68% <100.00%> (ø)
unit 40.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainMuller RomainMuller added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 581e992 Aug 20, 2024
20 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/packages.Load branch August 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants