This repository has been archived by the owner on Jan 21, 2025. It is now read-only.
Add Datadog reporter #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nsavoire
commented
May 17, 2024
nsavoire
commented
- Add options to control reporter interval / sampling frequency / profile dump
- Add Datadog reporter
- Make failure to get node name non-fatal and cache container metadata lookup failures
nsavoire
force-pushed
the
nsavoire/datadog_exporter
branch
from
f3f3166 to
6b6e932
Compare
r1viollet
reviewed
May 22, 2024
| @@ -292,7 +292,7 @@ func mainWithExitCode() exitCode { | |||
| // Network operations to CA start here | |||
| var rep reporter.Reporter | |||
| // Connect to the collection agent | |||
| rep, err = reporter.StartOTLP(mainCtx, &reporter.Config{ | |||
There was a problem hiding this comment.
There is a architecture discussion here around how we want to build the compability long term with the Otel collectors.
I am fine with this approach for now.
There was a problem hiding this comment.
Agree, the goal here is to have a version running quicky
r1viollet
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.