This repository has been archived by the owner on Jan 21, 2025. It is now read-only.
Improve build image #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting GOPATH to point inside agent directory has some undesirable side effects, such as make `go test ./...` fail ( because it tries to execute tests in ./go directory).
Add a `build` user and run container with this user by default. This allows mounting local agent directory in the docker container while still the right uid permissions. Allow this user to sudo in order to run the otel agent.
Gandem
pushed a commit
that referenced
this pull request
Jun 26, 2024
* Avoid setting GOPATH in docker image Setting GOPATH to point inside agent directory has some undesirable side effects, such as make `go test ./...` fail ( because it tries to execute tests in ./go directory). * Add a 'build' user Add a `build` user and run container with this user by default. This allows mounting local agent directory in the docker container while still the right uid permissions. Allow this user to sudo in order to run the otel agent.
Gandem
pushed a commit
that referenced
this pull request
Jun 27, 2024
* Avoid setting GOPATH in docker image Setting GOPATH to point inside agent directory has some undesirable side effects, such as make `go test ./...` fail ( because it tries to execute tests in ./go directory). * Add a 'build' user Add a `build` user and run container with this user by default. This allows mounting local agent directory in the docker container while still the right uid permissions. Allow this user to sudo in order to run the otel agent.
Gandem
pushed a commit
that referenced
this pull request
Jun 28, 2024
* Avoid setting GOPATH in docker image Setting GOPATH to point inside agent directory has some undesirable side effects, such as make `go test ./...` fail ( because it tries to execute tests in ./go directory). * Add a 'build' user Add a `build` user and run container with this user by default. This allows mounting local agent directory in the docker container while still the right uid permissions. Allow this user to sudo in order to run the otel agent.
Gandem
pushed a commit
that referenced
this pull request
Jun 28, 2024
* Avoid setting GOPATH in docker image Setting GOPATH to point inside agent directory has some undesirable side effects, such as make `go test ./...` fail ( because it tries to execute tests in ./go directory). * Add a 'build' user Add a `build` user and run container with this user by default. This allows mounting local agent directory in the docker container while still the right uid permissions. Allow this user to sudo in order to run the otel agent.
nsavoire
added a commit
that referenced
this pull request
Sep 3, 2024
* Avoid setting GOPATH in docker image Setting GOPATH to point inside agent directory has some undesirable side effects, such as make `go test ./...` fail ( because it tries to execute tests in ./go directory). * Add a 'build' user Add a `build` user and run container with this user by default. This allows mounting local agent directory in the docker container while still the right uid permissions. Allow this user to sudo in order to run the otel agent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting GOPATH to point inside agent directory has some undesirable side effects, such as make
go test ./...fail ( because it tries to execute tests in ./go directory).builduserAdd a
builduser and run container with this user by default.This allows mounting local agent directory in the docker container while still the right uid permissions.
Allow this user to sudo in order to run the otel agent.