This repository has been archived by the owner on Jan 21, 2025. It is now read-only.
[PROF-9929] Export profiles as native family #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gandem
previously approved these changes
Jun 12, 2024
You're right, I will update it ! |
nsavoire
force-pushed
the
nsavoire/export_as_native
branch
from
fd9513b to
72f5802
Compare
nsavoire
changed the title
r1viollet
reviewed
Jun 12, 2024
| @@ -323,7 +323,7 @@ func (r *DatadogReporter) reportProfile(ctx context.Context) error { | |||
| } | |||
|
|
|||
| tags := strings.Split(config.ValidatedTags(), ";") | |||
| tags = append(tags, "runtime:go") | |||
| tags = append(tags, "runtime:native") | |||
There was a problem hiding this comment.
We might want to change the actual runtime at one point if we want to make special rules to avoid having a service view.
Though I am fine with this 👍
Gandem
pushed a commit
that referenced
this pull request
Jun 26, 2024
Gandem
pushed a commit
that referenced
this pull request
Jun 27, 2024
Gandem
pushed a commit
that referenced
this pull request
Jun 28, 2024
Gandem
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.