🎨 [RUM-6567] Add new fields for Web Vitals attribution and other performance data #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethfowler-datadog
force-pushed
the
seth.fowler/new-web-vitals-attribution-fields
branch
from
36815bb to
3df6d79
Compare
sethfowler-datadog
force-pushed
the
seth.fowler/new-web-vitals-attribution-fields
branch
from
3df6d79 to
ffa51d2
Compare
sethfowler-datadog
changed the title
sethfowler-datadog
changed the title
thomas-lebeau
approved these changes
Dec 24, 2024
nulrich
approved these changes
Dec 24, 2024
amortemousque
approved these changes
Dec 24, 2024
sethfowler-datadog
deleted the
seth.fowler/new-web-vitals-attribution-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
RumPerformanceDatasubobject withinRumViewEvent. We'll gradually migrate performance-related fields fromRumViewEventinto this subobject, taking the opportunity to reorganize them in a cleaner, more hierarchical fashion.We begin the migration process within this PR by creating new versions of the Web-Vitals-related fields on
RumViewEventthat live inRumViewEvent. In the new structure, these fields are organized hierarchically, so that all of the fields for each Web Vital live on a subobject and attribution data for each Web Vital is cleanly tied to the Web Vital's primary metric.