Add the PR commented state #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouetz
force-pushed
the
nschweitzer/commented
branch
from
da26dbc
to
1791f72
Compare
AlexandreYang
previously approved these changes
Nov 24, 2023
FlorentClarret
previously approved these changes
Nov 24, 2023
| @@ -60,10 +64,14 @@ def main(config: Config) -> None: | |||
|
|
|||
There was a problem hiding this comment.
@chouetz
Since completely removing :review_started: could be a possible breaking change (no high risk though, it's just slack emojis.
What we can possibly do is to not add "review started" when "commented" is defined.
from:
new_emojis = {config.emoji_review_started}
into:
new_emojis = {}
if not config.emoji_commented:
new_emojis.add(config.emoji_review_started)
10 tasks
chouquette
reviewed
Nov 27, 2023
chouetz
dismissed stale reviews from FlorentClarret and AlexandreYang
via
793d949
chouetz
force-pushed
the
nschweitzer/commented
branch
from
1791f72
to
793d949
Compare
chouetz
force-pushed
the
nschweitzer/commented
branch
from
793d949
to
6685870
Compare
chouetz
force-pushed
the
nschweitzer/commented
branch
from
6685870
to
443d699
Compare
spencergilbert
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not tested