Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update and activate remote config tests for extra services #1623

Merged
merged 14 commits into from
Sep 27, 2023
Merged

update and activate remote config tests for extra services #1623

merged 14 commits into from
Sep 27, 2023

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Sep 26, 2023 •
edited
Loading

Description

  • activate Test_RemoteConfigurationExtraServices for python
  • update tests/remote_config/test_remote_configuration.py and add checks in test_tracer_extra_services
  • update flask and django weblog with new API for extra services

Motivation

With DataDog/dd-trace-py#6929, python tracer will implement the extra service names report feature. Once it is merged, we should activate those tests for the tracer. [merge done]

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@christophe-papazian christophe-papazian mentioned this pull request Sep 26, 2023
Merged
18 tasks
christophe-papazian added a commit to DataDog/dd-trace-py that referenced this pull request Sep 27, 2023
@christophe-papazian
feat(tracer): collect and report multiple service names (#6929)
4cb41f0 
Implementation of RFC "Service Names - Handling Inferred (Fake)
Services"

- add a multiprocessing queue to config
- all workers will push discovered sub-services names on the queue
- main thread will pull all names and send them to agent using Remote
Config
- add two unit tests and update one RC test
- it will also be validated by system tests 
   DataDog/system-tests#1623

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- [x] If this PR touches code that signs or publishes builds or
packages, or handles credentials of any kind, I've requested a review
from `@DataDog/security-design-and-guidance`.
- [x] This PR doesn't touch any of that.
robertpi
robertpi approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@robertpi robertpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot of noise from code cleaning, but the changes to the logic of the test seem to be an improvement.

@christophe-papazian christophe-papazian marked this pull request as ready for review September 27, 2023 11:05
@christophe-papazian @cbeauchesne
Update tests/remote_config/test_remote_configuration.py
902e732 
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
@christophe-papazian christophe-papazian merged commit 67eece9 into main Sep 27, 2023
@christophe-papazian christophe-papazian deleted the christophe-papazian/multiple_services_report branch September 27, 2023 11:22
tabgok pushed a commit to DataDog/dd-trace-py that referenced this pull request Sep 28, 2023
@christophe-papazian @tabgok
feat(tracer): collect and report multiple service names (#6929)
ccff0d0 
Implementation of RFC "Service Names - Handling Inferred (Fake)
Services"

- add a multiprocessing queue to config
- all workers will push discovered sub-services names on the queue
- main thread will pull all names and send them to agent using Remote
Config
- add two unit tests and update one RC test
- it will also be validated by system tests 
   DataDog/system-tests#1623

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- [x] If this PR touches code that signs or publishes builds or
packages, or handles credentials of any kind, I've requested a review
from `@DataDog/security-design-and-guidance`.
- [x] This PR doesn't touch any of that.
@smola smola mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@robertpi robertpi robertpi approved these changes

@avara1986 avara1986 Awaiting requested review from avara1986 avara1986 is a code owner automatically assigned from DataDog/apm-python

@ZStriker19 ZStriker19 Awaiting requested review from ZStriker19 ZStriker19 is a code owner automatically assigned from DataDog/apm-python

Assignees
No one assigned
Labels
run-all-scenarios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophe-papazian @robertpi @cbeauchesne