Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "skip APPSEC_MISSING_RULES for ruby (APPSEC-54708)" #3000

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Revert "skip APPSEC_MISSING_RULES for ruby (APPSEC-54708)" #3000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
098b6a8
Revert "skip APPSEC_MISSING_RULES for ruby (APPSEC-54708)"
TonyCTHsu Sep 9, 2024
9e7a5ce
Revert "skip also APPSEC_CORRUPTED_RULES"
TonyCTHsu Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/run-end-to-end.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,7 @@ jobs:
DD_API_KEY: ${{ secrets.DD_API_KEY }}
- name: Run APPSEC_MISSING_RULES scenario
# C++ 1.2.0 freeze when the rules file is missing
# ruby freeze when the rules file is missing (APPSEC-54708)
if: always() && steps.build.outcome == 'success' && contains(inputs.scenarios, '"APPSEC_MISSING_RULES"') && inputs.library != 'cpp' && inputs.library != 'ruby'
if: always() && steps.build.outcome == 'success' && contains(inputs.scenarios, '"APPSEC_MISSING_RULES"') && inputs.library != 'cpp'
run: ./run.sh APPSEC_MISSING_RULES
env:
DD_API_KEY: ${{ secrets.DD_API_KEY }}
Expand All @@ -189,7 +188,7 @@ jobs:
DD_API_KEY: ${{ secrets.DD_API_KEY }}
- name: Run APPSEC_CORRUPTED_RULES scenario
# C++ 1.2.0 freeze when the rules file is missing
if: always() && steps.build.outcome == 'success' && contains(inputs.scenarios, '"APPSEC_CORRUPTED_RULES"') && inputs.library != 'cpp' && inputs.library != 'ruby'
if: always() && steps.build.outcome == 'success' && contains(inputs.scenarios, '"APPSEC_CORRUPTED_RULES"') && inputs.library != 'cpp'
run: ./run.sh APPSEC_CORRUPTED_RULES
env:
DD_API_KEY: ${{ secrets.DD_API_KEY }}
Expand Down
Loading