Ruby:Update manifest for RC tests #3011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertomonteromiguel
requested changes
Sep 11, 2024
| @@ -452,6 +457,7 @@ class TestDynamicConfigV1_ServiceTargets: | |||
| ], | |||
| ) | |||
| @bug(library="nodejs") | |||
| @bug(library="ruby") | |||
rachelyangdog
approved these changes
Sep 17, 2024
cbeauchesne
requested changes
Sep 18, 2024
| @@ -298,6 +298,7 @@ def test_telemetry_app_started(self, library_env, test_agent, test_library): | |||
| assert len(events) > 0 | |||
|
|
|||
| @parametrize("library_env", [{**DEFAULT_ENVVARS}]) | |||
| @bug(library="ruby", reason="Telemetry event 'app-client-configuration-change' not found") | |||
There was a problem hiding this comment.
Can you set a JIRA ticket as reason for all bug declaration (see https://dd.slack.com/archives/C025TJ4RZ8X/p1726490527322989)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables enables previously skipped dynamic configuration, which are going to be fixed in the Ruby tracer 2.3.0, due to missing capabilities being reported (fixed in DataDog/dd-trace-rb#3888).
Also, this PR enables few
XPASStests for dynamic configuration.Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present