Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for ubuntu 20.04 #3104

Closed
wants to merge 3 commits into from
Closed

add tests for ubuntu 20.04 #3104

wants to merge 3 commits into from

Conversation

emmettbutler
Copy link
Contributor

@emmettbutler emmettbutler commented Sep 23, 2024

This change adds Ubuntu 20.04 arm and amd64 to the list of operating systems tested for single-step instrumentation compatibility.

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@emmettbutler emmettbutler requested a review from a team as a code owner September 23, 2024 20:44
@emmettbutler emmettbutler marked this pull request as draft September 23, 2024 20:44
@emmettbutler emmettbutler marked this pull request as ready for review September 24, 2024 18:22
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set this new vm as default for now

utils/_context/virtual_machines.py Show resolved Hide resolved
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`Diagnostics:
pulumi:pulumi:Stack (system-tests-vms-system-tests_onboarding):
error: update failed

aws:ec2:Instance (Ubuntu_20_amd64):
error: 1 error occurred:
* creating EC2 Instance: OptInRequired: In order to use this AWS Marketplace product you need to accept terms and subscribe. To do so please visit https://aws.amazon.com/marketplace/pp?sku=9rxhntdy981dz5t3gbzpdd60w
status code: 401, request id: a61747bb-600c-4e24-a23c-00ebfe4ecfa1
`

@emmettbutler emmettbutler deleted the emmett.butler/ubuntu20 branch October 3, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants