Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable trace sampling tests for Ruby #3177

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

ZStriker19
Copy link
Contributor

Motivation

When this PR merges Ruby tracer master branch will pass all of the trace sampling tests (tested this locally)
DataDog/dd-trace-rb#3956

Changes

Enable lazy sampling/ tag and resource sampling tests for Ruby tracer.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@ZStriker19 ZStriker19 marked this pull request as ready for review October 7, 2024 20:30
@ZStriker19 ZStriker19 requested review from a team as code owners October 7, 2024 20:30
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small hint for future PR : when your change only impacts ruby, you can prefix your PR title with [ruby] -> it will run only ruby in the CI.

In theory, it's automatic when you modify only a manifest files. But the current logic failed to understand that the modif on the doc file has no impact, and thus ran all langs 🤦 .

@ZStriker19 ZStriker19 merged commit ab4858f into main Oct 9, 2024
295 of 300 checks passed
@ZStriker19 ZStriker19 deleted the zachg/ruby_tags_and_resource_sampling branch October 9, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants