[resource_datadog_logs_index] Fix having zero retention logs indexes with flex #2716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The resource currently has two issues:
Changes
Context: While the endpoint is marked as a
PUT
it acts as aPATCH
(docs)On creation
If the resource has a
flex_retention_days
set, but noretention_days
, it will default to0
forretention_days
.On update
The previous
GetOk
check would turn0
intonull
, making it impossible to remove theretention_days
.The new condition does an explicit IsNull check to allow through
0
values.