Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPS-2248] [APPS-2144] App Builder Terraform Provider #2723

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

tyffical
Copy link

@tyffical tyffical commented Dec 16, 2024

Motivation

  • Adds the TF provider for the new App Builder Public API.
  • Includes
    • A data source for using Apps outside of resource definitions
    • A resource for managing Apps
    • Support for importing existing Apps as resources.
  • Usage: copy and paste App definition JSON from App Builder's JSON editor into Terraform
    • We don't expect users to really create Apps from scratch using TF syntax (too complex). If users come to want this, we will put it in future work.

References

Testing

  • Local manual testing (CRUD)
  • Record test cassettes with test org (TODO, debugging)

Wait Before Merging

Open Questions

  • Currently, this resource is called datadog_app. The plan is, in the future, updating this resource with extra structs in order to build an app in TF with TF syntax, strongly typing structs like queries and components.
    • Alternatively, what about creating a separate resource? This would help with making the code cleaner and disambiguate the two use cases. For instance, this resource would instead be datadog_app_json similar to how dashboards has a datadog_dashboard_json, and the non-json usage would be called datadog_app, like how dashboards also has datadog_dashboard.

@tyffical tyffical self-assigned this Dec 16, 2024
@tyffical tyffical force-pushed the tiffany.trinh/apps-2144-terraform branch 2 times, most recently from c37ed5c to 8006937 Compare December 18, 2024 19:32
@tyffical tyffical force-pushed the tiffany.trinh/apps-2144-terraform branch 2 times, most recently from 0e763b7 to 422a9c9 Compare January 13, 2025 19:44
Copy link
Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tyffical tyffical force-pushed the tiffany.trinh/apps-2144-terraform branch from e7878b0 to 25dde39 Compare January 24, 2025 22:02
@tyffical tyffical changed the title scaffold app in tf provider [WIP] App Builder Terraform Provider Jan 24, 2025
@tyffical tyffical changed the title [WIP] App Builder Terraform Provider [WIP] [APPS-2132] [APPS-2144] App Builder Terraform Provider Jan 24, 2025
@tyffical tyffical force-pushed the tiffany.trinh/apps-2144-terraform branch from ce431ec to 19f3d2b Compare January 27, 2025 22:38
@tyffical tyffical changed the title [WIP] [APPS-2132] [APPS-2144] App Builder Terraform Provider [WIP] [APPS-2248] [APPS-2144] App Builder Terraform Provider Jan 29, 2025
@tyffical tyffical requested a review from oliverli February 4, 2025 21:15
@tyffical tyffical changed the title [WIP] [APPS-2248] [APPS-2144] App Builder Terraform Provider [APPS-2248] [APPS-2144] App Builder Terraform Provider Feb 4, 2025
@tyffical tyffical force-pushed the tiffany.trinh/apps-2144-terraform branch from 07cf33b to 02d8ac5 Compare February 4, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant